Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add totalconnect zones as binary sensors #28712

Merged
merged 60 commits into from Feb 1, 2020
Merged

Conversation

@austinmroczek
Copy link
Contributor

austinmroczek commented Nov 12, 2019

Description:

Represent totalconnect "zones" as Home Assistant binary sensors.

This will add a large number of entities. It's 46 for my setup.

Related issue (if applicable): fixes craigjmidwinter/total-connect-client#2

**Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11160

Example entry for configuration.yaml (if applicable):

no changes to config

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • [n/a] Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • [n/a] Tests have been added to verify that the new code works.
austinmroczek added 30 commits Apr 14, 2019
update to latest HA
it is a burglar or fire or carbon monoxide so automations can take
appropriate actions.  Updated TotalConnect component to handle these new
states.
update
Also bumps total_connect_client to 0.27.
…. Bump total_connect_client to 0.28.
pull in latest
Dev automation moved this from Needs review to Review in progress Jan 18, 2020
@austinmroczek

This comment has been minimized.

Copy link
Contributor Author

austinmroczek commented Jan 19, 2020

I addressed all of your comments and changes, but I made changes locally instead of using the Github web interface. I think that's why it's still complaining you asked for changes.

Copy link
Contributor Author

austinmroczek left a comment

I think this closes out the "review." Sorry still fairly new to git and Github.

Dev automation moved this from Review in progress to Reviewer approved Jan 20, 2020
@springstan springstan changed the title Add totalconnect Zones as HA binary sensors Add totalconnect zones as binary sensors Jan 21, 2020
Co-Authored-By: springstan <46536646+springstan@users.noreply.github.com>
@springstan

This comment has been minimized.

Copy link
Member

springstan commented Jan 29, 2020

@MartinHjelmare could you please take a look at this to make sure I am not missing something? Thanks 👍

Dev automation moved this from Reviewer approved to Review in progress Jan 29, 2020
Dev automation moved this from Review in progress to Reviewer approved Jan 31, 2020
Copy link
Member

MartinHjelmare left a comment

Looks good!

@springstan springstan merged commit f584df4 into home-assistant:dev Feb 1, 2020
10 checks passed
10 checks passed
CI Build #20200131.56 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 95.33% of diff hit (target 94.56%)
Details
codecov/project 94.63% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Feb 1, 2020
@lock lock bot locked and limited conversation to collaborators Feb 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.