Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add MELCloud integration #30712
This stuff is not supported nor in any way affiliated with Mitsubishi Electric.
Provides climate and sensor platforms for Mitsubishi Electric heat pumps connected to MELCloud service. Multiple platforms on one go is not the best option, but it does not make sense to remove them and commit them later either. This thing started as a
Email and access token are stored to the ConfigEntry. The token can be updated by adding the integration again with the same email address. The config flow is aborted and the update is performed on the background. This is a bit unorthodox, but at least I like it better than storing the plain-text password.
Link to documentation pull request: home-assistant/home-assistant.io#11930
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
I attempted to test this component on my own HA install, but it appears to assume that MELCloud is only used for HVAC/AC systems. When tested with my system (simply an air-to-water system), I noted that the component just presumed that I had an HVAC system. It also doesn't show any zones, and only the first sensor (the power one) reports anything.
Is this out of scope of this PR, or is this unintentional?
I think the air-to-water systems are out of scope, but the lack of filtering is not. I also noticed I'm not filtering out empty model numbers for that device info like I though I did.
I have some read-only stuff for air-to-water systems here, but it has just temperatures for now. I would need help with that because I'm doing this with a blackbox or record/replay type approach (just in case) and therefore I don't have access to the source code of the original application. Help would be appreaciated. Right now it would be awesome to have captures of
* any -> Any * Better names for dict iterations * Proper dict access with mandatory/known keys * Remove unused 'name' argument * Remove unnecessary platform info from unique_ids * Remove redundant methods from climate platform * Remove redundant default value from dict get * Update ConfigFlow sub-classing * Define sensors in a dict instead of a list
@@ Coverage Diff @@ ## dev #30712 +/- ## ======================================= Coverage 94.64% 94.64% ======================================= Files 758 758 Lines 54882 54882 ======================================= Hits 51943 51943 Misses 2939 2939