Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hourly forecast in IPMA #30979

Merged
merged 19 commits into from Feb 14, 2020
Merged

Allow hourly forecast in IPMA #30979

merged 19 commits into from Feb 14, 2020

Conversation

@abmantis
Copy link
Contributor

abmantis commented Jan 19, 2020

Description:

Add support for hourly forecast, in addition to the existing daily forecast. This is controlled by a new "mode" config attribute.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11809

Example entry for configuration.yaml (if applicable):

weather:
  - platform: ipma
    name: Home
    latitude: 123.123
    longitude: -1.234
    mode: hourly

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

abmantis added 11 commits Jan 11, 2020
…into pyipma_update
…into pyipma_update
…into pyipma_update
…into pyipma_update
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Jan 19, 2020

Hey there @dgomes, mind taking a look at this pull request as its been labeled with a integration (ipma) you are listed as a codeowner for? Thanks!

@abmantis abmantis mentioned this pull request Jan 19, 2020
2 of 2 tasks complete
@dgomes

This comment has been minimized.

Copy link
Contributor

dgomes commented Jan 19, 2020

I think this will need to be rebased after #30746

@abmantis abmantis force-pushed the abmantis:pyipma_hourly branch 2 times, most recently from c24e842 to 778342a Jan 20, 2020
abmantis added 3 commits Jan 20, 2020
@abmantis abmantis force-pushed the abmantis:pyipma_hourly branch from 07d6b36 to baae1e9 Jan 20, 2020
abmantis added 2 commits Jan 21, 2020
…into pyipma_hourly
…into pyipma_hourly
@abmantis

This comment has been minimized.

Copy link
Contributor Author

abmantis commented Jan 29, 2020

@dgomes can you review please?

@dgomes
dgomes approved these changes Jan 29, 2020
homeassistant/components/ipma/weather.py Outdated Show resolved Hide resolved
tests/components/ipma/test_weather.py Show resolved Hide resolved
@abmantis

This comment has been minimized.

Copy link
Contributor Author

abmantis commented Feb 8, 2020

What is missing to merge this?

…into pyipma_hourly
@dgomes
dgomes approved these changes Feb 11, 2020
Copy link
Contributor

Adminiuga left a comment

lgtm

@Adminiuga Adminiuga merged commit e6148d2 into home-assistant:dev Feb 14, 2020
11 checks passed
11 checks passed
CI Build #20200208.4 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 96.91% of diff hit (target 94.62%)
Details
codecov/project 94.65% (target 90%)
Details
docs-missing Documentation ok.
@lock lock bot locked and limited conversation to collaborators Feb 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.