Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize insteon code #31183

Merged
merged 2 commits into from Jan 30, 2020
Merged

Reorganize insteon code #31183

merged 2 commits into from Jan 30, 2020

Conversation

@teharris1
Copy link
Contributor

teharris1 commented Jan 26, 2020

Breaking change

The Insteon entity device state attributes were changed to conform to naming standards. Insteon Address is now insteon_address and Insteon Group is now insteon_group. Users may need to update automations and scripts that rely on these attributes.

Proposed change

Reorganize the insteon component code to make future edits easier.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
insteon:
  port: /dev/ttyUSB0

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@project-bot project-bot bot added this to Needs review in Dev Jan 26, 2020
Dev automation moved this from Needs review to Review in progress Jan 26, 2020
Copy link
Member

MartinHjelmare left a comment

Good!

Can be merged when the breaking change paragraph is updated. Please ping me when that is done.

Dev automation moved this from Review in progress to Reviewer approved Jan 28, 2020
@teharris1

This comment has been minimized.

Copy link
Contributor Author

teharris1 commented Jan 29, 2020

@MartinHjelmare I have added the paragraph to the breaking change section but I am not sure there is anything a user needs to do to cope with that change since I don't believe the attributes are used for anything other than documentation.

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Jan 29, 2020

Ok. I added a sentence about automations and scripts where it at least theoretically could be used.

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Jan 29, 2020

Let's wait with merging this until the beta for 0.105 is cut later today. Then there's more time for further PRs with breaking changes for this integration this release cycle.

@pvizeli pvizeli merged commit 7ff30fe into home-assistant:dev Jan 30, 2020
11 checks passed
11 checks passed
CI Build #20200128.5 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing c477287...db1e987
Details
codecov/project 94.4% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Jan 30, 2020
@lock lock bot locked and limited conversation to collaborators Jan 31, 2020
@teharris1 teharris1 deleted the teharris1:reorg branch Feb 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can鈥檛 perform that action at this time.