Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos found by codespell #31243

Merged
merged 12 commits into from Jan 31, 2020
Merged

Fix typos found by codespell #31243

merged 12 commits into from Jan 31, 2020

Conversation

@cclauss
Copy link
Contributor

cclauss commented Jan 28, 2020

Proposed change

Fix typos found by codespell.
Add tests to prevent backsliding.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@project-bot project-bot bot added this to Needs review in Dev Jan 28, 2020
@@ -73,7 +73,7 @@
"swell_dir_worded": ["Swell Direction", None],
"swell_height": ["Swell Height", "m"],
"swell_period": ["Swell Period", None],
"vis_km": ["Visability km", "km"],
"vis_km": ["Visibility km", "km"],

This comment has been minimized.

Copy link
@MartinHjelmare

MartinHjelmare Jan 28, 2020

Member

This is a breaking change as it affects the name and entity_id of the corresponding entity.

This comment has been minimized.

Copy link
@cclauss

cclauss Jan 28, 2020

Author Contributor

Reverted.

@@ -160,7 +160,7 @@ def setup_platform(hass, config, add_entities, discovery_info=None):

# Changing inverter temperature unit.
sensors = deepcopy(SENSOR_TYPES)
if status.inverters.primary.temperature.units.farenheit:
if status.inverters.primary.temperature.units.fahrenheit:

This comment has been minimized.

Copy link
@MartinHjelmare

MartinHjelmare Jan 28, 2020

Member

How is this attribute spelled in the library?

This comment has been minimized.

Copy link
@cclauss

cclauss Jan 28, 2020

Author Contributor

Reverted.

@cclauss cclauss force-pushed the cclauss:fix-typos branch from 56e77e9 to efa1e42 Jan 28, 2020
@cclauss cclauss force-pushed the cclauss:fix-typos branch from 058a500 to 025a921 Jan 28, 2020
@frenck

This comment has been minimized.

Copy link
Member

frenck commented Jan 28, 2020

@cclauss Please don't squash and force push your changes. It is hard to follow for reviewers. Just push new commits on top of this PR, after approval, we squash the PR in the end. Thanks 馃憤

cclauss added 2 commits Jan 28, 2020
@cclauss cclauss requested a review from pnbruckner as a code owner Jan 30, 2020
@@ -1,4 +1,4 @@
"""Suppoort for Amcrest IP camera binary sensors."""
"""Support for Amcrest IP camera binary sensors."""

This comment has been minimized.

Copy link
@pnbruckner

pnbruckner Jan 30, 2020

Contributor

Wow, I must have a sticky keyboard. Thanks!

@springstan

This comment has been minimized.

Copy link
Member

springstan commented Jan 30, 2020

@cclauss please solve the merge conflict, thanks :)

cclauss added 2 commits Jan 30, 2020
@springstan

This comment has been minimized.

Copy link
Member

springstan commented Jan 30, 2020

Looks like you need to run codespell once again since the new addtions already have mistakes in them 馃槄

cclauss added 5 commits Jan 30, 2020
Dev automation moved this from Needs review to Reviewer approved Jan 30, 2020
@frenck
frenck approved these changes Jan 31, 2020
Copy link
Member

frenck left a comment

Looks good!

Copy link
Member

rohankapoorcom left a comment

This is awesome!

@cclauss

This comment has been minimized.

Copy link
Contributor Author

cclauss commented Jan 31, 2020

This PR touches so many files that conflicts can arise if it is not merged before other PRs that touch the same files.

@rohankapoorcom rohankapoorcom merged commit df7d2b3 into home-assistant:dev Jan 31, 2020
10 checks passed
10 checks passed
CI Build #20200130.113 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch No report found to compare against
Details
codecov/project 94.62% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Jan 31, 2020
@rohankapoorcom

This comment has been minimized.

Copy link
Member

rohankapoorcom commented Jan 31, 2020

Merged. We have enough approvals I think.

@cclauss cclauss deleted the cclauss:fix-typos branch Jan 31, 2020
Copy link
Member

springstan left a comment

Awesome addition! 馃帀

Dev automation moved this from Done to Reviewer approved Jan 31, 2020
@springstan springstan moved this from Reviewer approved to Done in Dev Jan 31, 2020
@springstan

This comment has been minimized.

Copy link
Member

springstan commented Jan 31, 2020

Looks like I was too late 馃榿

@lock lock bot locked and limited conversation to collaborators Feb 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can鈥檛 perform that action at this time.