Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let core resolve entity_id for lastfm from username #31280

Merged
merged 3 commits into from Jan 31, 2020

Conversation

@inverse
Copy link
Contributor

inverse commented Jan 29, 2020

This is the actual fix for #31162 that leads on from the initial work done in #31163 to ensure that entity IDs are unique.

The first PR was merged and should be released in 0.105 which will allow users that use the integration to have the unique ID set and avoid BC.

This one must be merged into the 0.106 release cycle.

inverse added 2 commits Jan 31, 2020
@inverse inverse changed the title Fix lastfm integration for usernames with period Let core resolve entity_id for lastfm from username Jan 31, 2020
Dev automation moved this from Needs review to Reviewer approved Jan 31, 2020
@balloob balloob merged commit ae76b5b into home-assistant:dev Jan 31, 2020
10 checks passed
10 checks passed
CI Build #20200131.61 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 61e41f0...dd690e9
Details
codecov/project 94.62% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Jan 31, 2020
@inverse inverse deleted the inverse:fix-lastfm-proper branch Feb 1, 2020
@inverse

This comment has been minimized.

Copy link
Contributor Author

inverse commented Feb 1, 2020

@MartinHjelmare 🙏 thanks so much for helping me get my first contributions into this community

@springstan springstan mentioned this pull request Feb 2, 2020
4 of 4 tasks complete
@lock lock bot locked and limited conversation to collaborators Feb 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.