Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline SimpliSafe data and token management #31324

Merged
merged 4 commits into from Feb 3, 2020

Conversation

@bachya
Copy link
Contributor

bachya commented Jan 30, 2020

Proposed change

This PR streamlines SimpliSafe's data management in a few key ways:

  1. A lot of data initialization logic that was hanging out in async_setup has been moved to the data object.
  2. The emergency refresh token logic was being applied to multiple tasks at the same time, which muddied things (and likely added to the issues). This PR extrapolates that to a single update that cancels all other tasks if one fails.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
simplisafe:
  accounts:
    username: !secret simplisafe_username
    password: !secret simplisafe_password

Additional information

  • This PR fixes or closes issue: N/A
  • This PR is related to issue: N/A
  • Link to documentation pull request: N/A

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@bachya bachya self-assigned this Jan 30, 2020
@project-bot project-bot bot added this to Needs review in Dev Jan 30, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Jan 30, 2020
bachya added 2 commits Jan 31, 2020
Copy link
Member

MartinHjelmare left a comment

Looks good!

Dev automation moved this from By Code Owner to Reviewer approved Feb 3, 2020
@bachya bachya merged commit 2610415 into home-assistant:dev Feb 3, 2020
10 checks passed
10 checks passed
CI Build #20200131.2 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 9432054...430f62f
Details
codecov/project 94.62% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Feb 3, 2020
@bachya bachya deleted the bachya:ss-updates branch Feb 3, 2020
@lock lock bot locked and limited conversation to collaborators Feb 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.