Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axis - Use core to start component tests #31328

Merged
merged 3 commits into from Jan 31, 2020

Conversation

@Kane610
Copy link
Member

Kane610 commented Jan 30, 2020

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue: #31286
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@Kane610 Kane610 requested a review from MartinHjelmare Jan 30, 2020
@Kane610 Kane610 self-assigned this Jan 30, 2020
@project-bot project-bot bot added this to Needs review in Dev Jan 30, 2020
Copy link
Member

MartinHjelmare left a comment

There are two more places, line 50 and 71, in the module where we access axis component functions directly instead of going via core. Can we change those too?

@MartinHjelmare MartinHjelmare changed the title Axis - Fix test according to Martins comment in 31286 Axis - Use core to start component tests Jan 30, 2020
@Kane610

This comment has been minimized.

Copy link
Member Author

Kane610 commented Jan 31, 2020

There are two more places, line 50 and 71, in the module where we access axis component functions directly instead of going via core. Can we change those too?

71 is a method only called by Axis async_setup_entry, do you mean 50 and 60? async_setup_entry and async_unload_entry

@balloob balloob mentioned this pull request Jan 31, 2020
1 of 6 tasks complete
@Kane610

This comment has been minimized.

Copy link
Member Author

Kane610 commented Jan 31, 2020

@MartinHjelmare all done!

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Jan 31, 2020

Instead of calling async_populate_options directly we can set up the entry and check that the options are populated ok in the entry afterwards. That way we can change this function, rename it or do something else, without changing the test.

This is the cool thing if we use the core both to start the test and to assert state.

@Kane610

This comment has been minimized.

Copy link
Member Author

Kane610 commented Jan 31, 2020

Instead of calling async_populate_options directly we can set up the entry and check that the options are populated ok in the entry afterwards. That way we can change this function, rename it or do something else, without changing the test.

Gotcha! Will do

@Kane610

This comment has been minimized.

Copy link
Member Author

Kane610 commented Jan 31, 2020

Copy link
Member

MartinHjelmare left a comment

Nice!

Dev automation moved this from Needs review to Reviewer approved Jan 31, 2020
@Kane610 Kane610 merged commit 44f0728 into home-assistant:dev Jan 31, 2020
10 checks passed
10 checks passed
CI Build #20200131.51 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 56657fa...3ba430c
Details
codecov/project 94.63% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Jan 31, 2020
@Kane610 Kane610 deleted the Kane610:axis-fix_config_flow_test branch Jan 31, 2020
@lock lock bot locked and limited conversation to collaborators Feb 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.