Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Throttle on async_setup and bump pyvizio version #31337

merged 5 commits into from Jan 31, 2020


Copy link

raman325 commented Jan 31, 2020

Proposed change

Update vizio component:

  • Bump pyvizio to latest version (1.12) - no integration affecting changes from version bump
  • Remove Throttle decorator and rely solely on SCAN_INTERVAL (the Throttle was effectively acting as the SCAN_INTERVAL

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests


  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@project-bot project-bot bot added this to Needs review in Dev Jan 31, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Jan 31, 2020
Copy link

amelchio left a comment

Nice cleanup 馃憤

Dev automation moved this from By Code Owner to Reviewer approved Jan 31, 2020
raman325 added 4 commits Jan 31, 2020
@amelchio amelchio merged commit a0067a2 into home-assistant:dev Jan 31, 2020
10 checks passed
10 checks passed
CI Build #20200131.18 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 611127a...3986041
codecov/project 94.62% (target 90%)
Dev automation moved this from Reviewer approved to Done Jan 31, 2020
@raman325 raman325 deleted the raman325:vizio_remove_throttle branch Jan 31, 2020
@lock lock bot locked and limited conversation to collaborators Feb 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.