Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misspelled danfoss_air sensor names #31344

Merged
merged 1 commit into from Feb 3, 2020
Merged

Conversation

@KasperLK
Copy link
Contributor

KasperLK commented Jan 31, 2020

Breaking change

The names of some danfoss_air sensors include a misspelling of the word danfoss.
This typo has been corrected and you will need to adjust all occurrences respectively.
The following sensors are affected:

  • dandoss_air_dial_battery -> danfoss_air_dial_battery
  • dandoss_air_exhaust_fan_speed -> danfoss_air_exhaust_fan_speed
  • dandoss_air_supply_fan_speed -> danfoss_air_supply_fan_speed

Proposed change

Fix missspelled sensor names.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
@homeassistant

This comment has been minimized.

Copy link
Contributor

homeassistant commented Jan 31, 2020

Hi @KasperLK,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@KasperLK

This comment has been minimized.

Copy link
Contributor Author

KasperLK commented Jan 31, 2020

I'm not sure, but I think that this is a breaking change, as it might change the entity_id of the sensors.

@springstan

This comment has been minimized.

Copy link
Member

springstan commented Jan 31, 2020

I'm not sure, but I think that this is a breaking change, as it might change the entity_id of the sensors.

Yes that is a breaking change, please add a breaking change section to the PR template.

@springstan springstan changed the title Fix misspelled sensor names Fix misspelled danfoss_air sensor names Jan 31, 2020
Dev automation moved this from Needs review to Reviewer approved Feb 1, 2020
@rohankapoorcom

This comment has been minimized.

Copy link
Member

rohankapoorcom commented Feb 1, 2020

Shouldn't there be a docs update for fixing the spelling as well? Or are they correct in the docs and incorrect here?

@springstan

This comment has been minimized.

Copy link
Member

springstan commented Feb 1, 2020

@rohankapoorcom they are currently not listed in the docs, however you are right the docs should be updated.

@KasperLK could you please update the documentation to include all danfoss air sensors?
Thanks 👍

@KasperLK KasperLK mentioned this pull request Feb 3, 2020
1 of 5 tasks complete
@springstan springstan removed the docs-missing label Feb 3, 2020
@springstan springstan merged commit f5b7900 into home-assistant:dev Feb 3, 2020
10 of 11 checks passed
10 of 11 checks passed
docs-missing Please open a documentation PR.
CI Build #20200131.25 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot All contributors have signed the CLA
codecov/patch Coverage not affected.
Details
codecov/project 94.63% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Feb 3, 2020
@lock lock bot locked and limited conversation to collaborators Feb 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.