Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract services from init.py for HomematicIP Cloud #31376

Merged
merged 2 commits into from Feb 8, 2020

Conversation

@SukramJ
Copy link
Contributor

SukramJ commented Feb 1, 2020

Proposed change

This PR extracts the existing HomematicIP Cloud services to its own file.
It also checks if services should be unregistered if entry is unloaded.
This PR is basically inspired by deconz integration.

Existing tests for services did not have to be adapted for this PR.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@project-bot project-bot bot added this to Needs review in Dev Feb 1, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Feb 1, 2020
@SukramJ SukramJ force-pushed the SukramJ:HmIP-ReorgServices branch from a8b2481 to 725d27c Feb 1, 2020
@SukramJ SukramJ requested a review from MartinHjelmare Feb 1, 2020
@SukramJ SukramJ force-pushed the SukramJ:HmIP-ReorgServices branch from 83b74b6 to 5afbaea Feb 2, 2020
@SukramJ SukramJ force-pushed the SukramJ:HmIP-ReorgServices branch from ac8aa66 to c715896 Feb 3, 2020
@SukramJ

This comment has been minimized.

Copy link
Contributor Author

SukramJ commented Feb 8, 2020

Hi @MartinHjelmare,
please have a look at this PR.
Thanks a lot.

Copy link
Member

MartinHjelmare left a comment

Functionality hasn't changed except for the set up and unloading of the services, right?

Dev automation moved this from By Code Owner to Reviewer approved Feb 8, 2020
@SukramJ

This comment has been minimized.

Copy link
Contributor Author

SukramJ commented Feb 8, 2020

Correct.

@MartinHjelmare MartinHjelmare merged commit baa9184 into home-assistant:dev Feb 8, 2020
8 checks passed
8 checks passed
CI Build #20200203.93 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
Dev automation moved this from Reviewer approved to Done Feb 8, 2020
@SukramJ SukramJ deleted the SukramJ:HmIP-ReorgServices branch Feb 8, 2020
@lock lock bot locked and limited conversation to collaborators Feb 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.