Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyhomematic to 0.1.64 #31406

Merged
merged 1 commit into from Feb 2, 2020
Merged

Update pyhomematic to 0.1.64 #31406

merged 1 commit into from Feb 2, 2020

Conversation

@danielperna84
Copy link
Contributor

danielperna84 commented Feb 2, 2020

Type of change

Add support for devices HM-LC-DW-WM and HmIP-MOD-OC8. For HM-LC-DW-WM to work correctly PR #31207 has to be merged as well.

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Feb 2, 2020

Hey there @pvizeli, mind taking a look at this pull request as its been labeled with a integration (homematic) you are listed as a codeowner for? Thanks!

@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Feb 2, 2020
Dev automation moved this from By Code Owner to Reviewer approved Feb 2, 2020
@pvizeli
pvizeli approved these changes Feb 2, 2020
@pvizeli pvizeli merged commit 0f6e285 into home-assistant:dev Feb 2, 2020
11 checks passed
11 checks passed
CI Build #20200202.26 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 704cfcf...a295f0c
Details
codecov/project 94.62% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Feb 2, 2020
@lock lock bot locked and limited conversation to collaborators Feb 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.