Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sure Petcare new features various improvements #31437

Merged
merged 49 commits into from Feb 9, 2020

Conversation

@benleb
Copy link
Contributor

benleb commented Feb 3, 2020

Breaking change

  • removed household_id from configuration options as it is not needed anymore

Proposed change

  • add support for all four lock states
  • add basic support for Sure Petcare Hub
  • add support for the Sure Petcare Feeders (thanks to @AshScott from the home assistant forum)
  • Add Connectitvity and Battery Sensors for all supported devices
  • Cleanup code and simplify some things

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

surepetcare:
  username: YOUR_SURE_PETCARE_LOGIN
  password: YOUR_SURE_PETCARE_PASSWORD
  feeders: [12345, 67890]
  flaps: [13579]
  pets: [24680]

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
benleb added 30 commits Jan 18, 2020
鈥 hubs
鈥ass
@project-bot project-bot bot added this to Needs review in Dev Feb 3, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Feb 3, 2020
benleb added 4 commits Feb 3, 2020
@benleb benleb changed the title WIP: Sure Petcare new features various improvements Sure Petcare new features various improvements Feb 3, 2020
@benleb benleb requested a review from MartinHjelmare Feb 3, 2020
Copy link
Member

MartinHjelmare left a comment

Some small comments.

Please check the typing for the init methods of the classes.

Dev automation moved this from By Code Owner to Review in progress Feb 3, 2020
benleb added 5 commits Feb 9, 2020
Copy link
Member

MartinHjelmare left a comment

Looks good!

Dev automation moved this from Review in progress to Reviewer approved Feb 9, 2020
@codecov

This comment was marked as off-topic.

Copy link

codecov bot commented Feb 9, 2020

Codecov Report

Merging #31437 into dev will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #31437   +/-   ##
=======================================
  Coverage   94.65%   94.65%           
=======================================
  Files         756      756           
  Lines       54808    54808           
=======================================
  Hits        51877    51877           
  Misses       2931     2931           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update fc013c9...fc013c9. Read the comment docs.

@springstan springstan merged commit fb2e120 into home-assistant:dev Feb 9, 2020
10 checks passed
10 checks passed
CI Build #20200209.26 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing fc013c9...fc013c9
Details
codecov/project 94.65% (target 90.00%)
Details
Dev automation moved this from Reviewer approved to Done Feb 9, 2020
@lock lock bot locked and limited conversation to collaborators Feb 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can鈥檛 perform that action at this time.