Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with Ambient PWS dispatcher topic #31439

Merged
merged 3 commits into from Feb 3, 2020

Conversation

@bachya
Copy link
Contributor

bachya commented Feb 3, 2020

Proposed change

This PR fixes two issues with the ambient_pws integration:

  1. When new data for any station was received, all entities (regardless of whether those entities belonged to that station) received a dispatcher message to update. Now, only appropriate entities are notified.
  2. The dispatcher topic was way too general and would be triggered by anything in HASS sending that topic (update). Now, the topic is much more specific.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
ambient_station:
  api_key: !ambient_api_key
  app_key: !ambient_app_key

Additional information

  • This PR fixes or closes issue: N/A
  • This PR is related to issue: N/A
  • Link to documentation pull request: N/A

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@bachya bachya changed the title Ambient dispatcher topic Fix issues with Ambient PWS dispatcher topic Feb 3, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #31439 into dev will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #31439      +/-   ##
==========================================
- Coverage   94.62%   94.62%   -0.01%     
==========================================
  Files         749      749              
  Lines       54224    54224              
==========================================
- Hits        51312    51309       -3     
- Misses       2912     2915       +3     
Impacted Files Coverage 螖
homeassistant/components/template/cover.py 96.34% <0.00%> (-1.37%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 8bc77f0...c342040. Read the comment docs.

Dev automation moved this from Needs review to Reviewer approved Feb 3, 2020
@bachya bachya merged commit bea7aae into home-assistant:dev Feb 3, 2020
10 checks passed
10 checks passed
CI Build #20200203.81 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 8bc77f0...c342040
Details
codecov/project 94.62% (target 90.00%)
Details
Dev automation moved this from Reviewer approved to Done Feb 3, 2020
@bachya bachya deleted the bachya:ambient-dispatcher-topic branch Feb 3, 2020
@lock lock bot locked and limited conversation to collaborators Feb 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.