Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update StepSpeaker and Speaker interfaces in Alexa #31444

Merged

Conversation

@ochlocracy
Copy link
Member

ochlocracy commented Feb 3, 2020

Proposed change

  • Yields only one of Alexa.Speaker or Alexa.StepSpeaker interface for media_player based on the support features.
  • Adds missing properties to the Alexa.Speaker interface.
  • Enables proactivelyReported properties for Alexa.Speaker interface.
  • Enables retrievable properties for Alexa.Speaker interface.
  • Refactors tests, breaking out tests for each of the speaker interfaces.
  • Fixes a bug when both Speaker interfaces are yielded for the same device.

Type of change

I'm checking 2 boxes 馃槣

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Feb 3, 2020

Hey there @home-assistant/cloud, mind taking a look at this pull request as its been labeled with a integration (alexa) you are listed as a codeowner for? Thanks!

@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Feb 3, 2020
@ochlocracy ochlocracy changed the title Update Steppeaker interfaces in Alexa Update StepSpeaker and Speaker interfaces in Alexa Feb 3, 2020
@balloob
balloob approved these changes Feb 3, 2020
Dev automation moved this from By Code Owner to Reviewer approved Feb 3, 2020
@balloob balloob merged commit c8d9b83 into home-assistant:dev Feb 3, 2020
9 of 10 checks passed
9 of 10 checks passed
codecov/patch 86.95% of diff hit (target 94.62%)
Details
CI Build #20200203.100 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/project 94.62% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Feb 3, 2020
@lock lock bot locked and limited conversation to collaborators Feb 4, 2020
@ochlocracy ochlocracy deleted the ochlocracy:alexa-improve-volume-controllers branch Feb 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.