Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link when IO in event loop #31519

Merged
merged 1 commit into from Feb 6, 2020
Merged

Update link when IO in event loop #31519

merged 1 commit into from Feb 6, 2020

Conversation

@balloob
Copy link
Member

balloob commented Feb 6, 2020

Breaking change

Proposed change

When fetching properties from an entity (there are no awaits in here) takes longer than 0.4 seconds, we log a warning. We used to redirect people to issue #4210 but as Frenck noted, that doesn't work with code owners. So this updates the message asking people to create a new issue.

Instead of linking people to the new issue page, I am linking them to the issue tracker filtered by the platform that was slow. That way people might spot an existing issue for I/O.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@balloob balloob requested a review from home-assistant/core as a code owner Feb 6, 2020
@project-bot project-bot bot added this to Needs review in Dev Feb 6, 2020
@frenck
frenck approved these changes Feb 6, 2020
Dev automation moved this from Needs review to Reviewer approved Feb 6, 2020
@MartinHjelmare MartinHjelmare merged commit a3b3924 into dev Feb 6, 2020
11 checks passed
11 checks passed
CI Build #20200206.4 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.62%)
Details
codecov/project 94.63% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Feb 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the issue-io-event-loop branch Feb 6, 2020
@lock lock bot locked and limited conversation to collaborators Feb 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can鈥檛 perform that action at this time.