Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the provider name to blockchain.com #31534

Merged
merged 2 commits into from Feb 6, 2020

Conversation

@P-Verbrugge
Copy link
Contributor

P-Verbrugge commented Feb 6, 2020

Blockchain.info moved from .info .com. Updated the name of the service to blockchain.com

Breaking change

None

Proposed change

Updated the Blockchain service name from blockchain.info to blockchain.com

Type of change

  • Code quality improvements to existing code or addition of tests

  • This PR fixes or closes issue: fixes #

  • This PR is related to issue:

  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
Blockchain.info moved from .info .com. Updated the name of the service to blockchain.com
Copy link
Contributor

Quentame left a comment

Also change in manifest.json

Dev automation moved this from Needs review to Review in progress Feb 6, 2020
Updated the provider name to blockchain.com
@P-Verbrugge

This comment has been minimized.

Copy link
Contributor Author

P-Verbrugge commented Feb 6, 2020

Also change in manifest.json

Done.

Next time I will see that I do a single pull request for two components when they are linked.

Copy link
Contributor

Quentame left a comment

Nice, also check home-assistant.io project to fix the documentation if needed.

You can tag me if you want.

Dev automation moved this from Review in progress to Reviewer approved Feb 6, 2020
@Quentame Quentame merged commit 4f21951 into home-assistant:dev Feb 6, 2020
8 checks passed
8 checks passed
CI Build #20200206.28 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
Dev automation moved this from Reviewer approved to Done Feb 6, 2020
@P-Verbrugge

This comment has been minimized.

Copy link
Contributor Author

P-Verbrugge commented Feb 6, 2020

Nice, also check home-assistant.io project to fix the documentation if needed.

You can tag me if you want.

Thanks for pointing that out. I just updated the documentation and tagged you (hopefully - learning the hard way).

@P-Verbrugge P-Verbrugge mentioned this pull request Feb 6, 2020
3 of 7 tasks complete
@lock lock bot locked and limited conversation to collaborators Feb 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.