Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix updates when Plex client viewing photos #31556

Merged
merged 1 commit into from Feb 6, 2020

Conversation

@jjlawren
Copy link
Contributor

jjlawren commented Feb 6, 2020

Proposed change

Ignores updates from Plex clients that are currently viewing photos. This will still count the photo session in the sensor which shows active clients, but will not expose anything via the media_player entities.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #31098

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@project-bot project-bot bot added this to Needs review in Dev Feb 6, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Feb 6, 2020
@balloob
balloob approved these changes Feb 6, 2020
Dev automation moved this from By Code Owner to Reviewer approved Feb 6, 2020
@balloob balloob merged commit 3a3328d into home-assistant:dev Feb 6, 2020
11 checks passed
11 checks passed
CI Build #20200206.78 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing d1e7ade...156c9bb
Details
codecov/project 94.65% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Feb 6, 2020
@jjlawren jjlawren deleted the jjlawren:plex_skip_photos branch Feb 7, 2020
@lock lock bot locked and limited conversation to collaborators Feb 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can鈥檛 perform that action at this time.