Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exceptions when using newer Samsung TVs #31602

merged 4 commits into from Feb 8, 2020


Copy link

escoand commented Feb 7, 2020

Breaking change


Proposed change

Catch exceptions from newer websocket TVs and show not supported message. This is a step back compared to pre-0.105 because we now do not add the newer TVs. Previously they were added but showed at least on/off state.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

This does not solve the issue #31504 but catches the exceptions.

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:


  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • [<] The code has been formatted using Black (black --fast homeassistant tests)
  • [<] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
escoand added 4 commits Feb 7, 2020
@project-bot project-bot bot added this to Needs review in Dev Feb 7, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Feb 7, 2020
@escoand escoand requested a review from MartinHjelmare Feb 7, 2020
Dev automation moved this from By Code Owner to Reviewer approved Feb 8, 2020
Copy link

MartinHjelmare left a comment

We're working on adding support for the newer TVs, right?


This comment has been minimized.

Copy link
Contributor Author

escoand commented Feb 8, 2020

Yes, see #31537.

@MartinHjelmare MartinHjelmare merged commit 0823ee4 into home-assistant:dev Feb 8, 2020
11 checks passed
11 checks passed
CI Build #20200207.51 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.63%)
codecov/project 94.65% (target 90%)
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Feb 8, 2020
@lock lock bot locked and limited conversation to collaborators Feb 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.