Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for spc power binary sensors #31611

Merged
merged 1 commit into from Feb 9, 2020
Merged

Conversation

@crallian
Copy link
Contributor

crallian commented Feb 7, 2020

Proposed change

Added support for the Zone type Technical visualized as binary_sensor of type 'power'. This can be used in SPC to track status of e.g. mapping keys and outputs.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
The zone type technical can be used in SPC to track status of e.g. mapping keys and outputs.
@homeassistant

This comment has been minimized.

Copy link
Contributor

homeassistant commented Feb 7, 2020

Hi @crallian,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@project-bot project-bot bot added this to Needs review in Dev Feb 7, 2020
@homeassistant homeassistant added cla-signed and removed cla-needed labels Feb 7, 2020
@springstan springstan changed the title Added zone type Technical as power. Add zone type technical as power device class Feb 7, 2020
@springstan

This comment has been minimized.

Copy link
Member

springstan commented Feb 8, 2020

@crallian please update the documentation for this integration accordingly by opening a PR in home-assistant/home-assistant.io :)

@springstan springstan changed the title Add zone type technical as power device class Add support for spc power binary sensors Feb 8, 2020
Copy link
Member

springstan left a comment

Looks fine to me 馃憤

Dev automation moved this from Needs review to Reviewer approved Feb 8, 2020
@crallian crallian mentioned this pull request Feb 9, 2020
2 of 7 tasks complete
@crallian

This comment has been minimized.

Copy link
Contributor Author

crallian commented Feb 9, 2020

Created pull request for updated documentation:
home-assistant/home-assistant.io#12025

@springstan springstan removed the docs-missing label Feb 9, 2020
@springstan springstan merged commit 645c673 into home-assistant:dev Feb 9, 2020
10 of 11 checks passed
10 of 11 checks passed
docs-missing Please open a documentation PR.
CI Build #20200207.58 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot All contributors have signed the CLA
codecov/patch Coverage not affected when comparing fd4f8d9...5972398
Details
codecov/project 94.65% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Feb 9, 2020
@lock lock bot locked and limited conversation to collaborators Feb 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.