Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hue to retry if hub errors out #31616

Merged
merged 3 commits into from Feb 8, 2020
Merged

Hue to retry if hub errors out #31616

merged 3 commits into from Feb 8, 2020

Conversation

@balloob
Copy link
Member

balloob commented Feb 8, 2020

Breaking change

Proposed change

Hue hubs have a max parallel connection limit that is global among clients. It means that sometimes we get an error, especially if other devices on the network also access Hue. This change retries twice when this happens.

Fixes #13389
Fixes #29152
Fixes #16689

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
balloob added 2 commits Feb 8, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 8, 2020

Codecov Report

Merging #31616 into dev will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #31616      +/-   ##
==========================================
- Coverage   94.65%   94.63%   -0.02%     
==========================================
  Files         754      754              
  Lines       54576    54585       +9     
==========================================
- Hits        51659    51658       -1     
- Misses       2917     2927      +10     
Impacted Files Coverage 螖
homeassistant/components/template/cover.py 96.34% <0.00%> (-1.37%) 猬囷笍
...ssistant/components/islamic_prayer_times/sensor.py 94.68% <0.00%> (-1.07%) 猬囷笍
homeassistant/components/statistics/sensor.py 89.47% <0.00%> (+0.06%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update d093b5f...e681e0a. Read the comment docs.

Dev automation moved this from Needs review to Reviewer approved Feb 8, 2020
@Quentame

This comment has been minimized.

Copy link
Contributor

Quentame commented Feb 8, 2020

Also fixes #31644 ?

Sent with GitHawk

@balloob balloob merged commit 989dd32 into dev Feb 8, 2020
9 of 10 checks passed
9 of 10 checks passed
codecov/patch 33.33% of diff hit (target 94.65%)
Details
CI Build #20200208.8 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/project 94.63% (target 90.00%)
Details
Dev automation moved this from Reviewer approved to Done Feb 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the hue-retries branch Feb 8, 2020
@lock lock bot locked and limited conversation to collaborators Feb 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can鈥檛 perform that action at this time.