Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Use latest version of python-pushover (forked) to fix issue with diff… #31647
…erent API tokens. (https://community.home-assistant.io/t/different-applications-in-pushover/6985)
There is a problem in the pushover integration. The underlying python lib stored the API token globally, so all notifies used one same API token, instead of possibly different tokens configured.
Type of change
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
The integration reached or maintains the following Integration Quality Scale:
I created a new issue on the project and didn't get a response. The last commit is over 2 years ago, the readme is not reflecting the latest code changes. Also if you look at the ha issue, there was already another user that tried to fix it and was always waiting to get his PR accepted. So it looks very dead to me...
But if you don't like what I did, what should I do instead. Write and publish a lib on my own (basically the same like the fork I did now)? Or look for another pushover library? Which may lead to a lot more code changes in the integration...
For us to accept a PR to change the lib of an integration:
Hmm ok, I'll try:
I opened another issue on that project to try to reach out to the maintainer, but no reaction at all: Thibauth/python-pushover#32
So I also consider this project as abandoned.
But if you don't like forks, here is another try: I'm now using the obviously still maintained library pushover_complete and rewrote the integration to use it.
Maybe you can now check the PR...