Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre-commit hook issue on Windows #31648

Merged
merged 3 commits into from Feb 18, 2020
Merged

Fix pre-commit hook issue on Windows #31648

merged 3 commits into from Feb 18, 2020

Conversation

@teharris1
Copy link
Contributor

teharris1 commented Feb 8, 2020

Proposed change

Update shebang in scripts/run-in-env.sh to be comparable with git on Windows per this pre-commit hook issue:
pre-commit/pre-commit#780 (comment)

Someone should definitely test this in *NIX environment before merge.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Pre-commit hook failes on Windows with error:
Executable /bin/sh not found

The proper format of the shebang is:
#!/usr/bin/env sh -eu

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
teharris1 added 3 commits Feb 8, 2020
@project-bot project-bot bot added this to Needs review in Dev Feb 8, 2020
@teharris1

This comment has been minimized.

Copy link
Contributor Author

teharris1 commented Feb 18, 2020

@scop Can you have a look at this PR? I am having issues with the pre-commit hooks due to an issue with mypy the this script/run-in-env.sh script. I think this is a straight forward change but best if you look at it.

@balloob balloob requested a review from scop Feb 18, 2020
Copy link
Member

balloob left a comment

Tested locally, works on Mac.

Thanks for the fix.

Dev automation moved this from Needs review to Reviewer approved Feb 18, 2020
@balloob balloob merged commit f6540e3 into home-assistant:dev Feb 18, 2020
11 checks passed
11 checks passed
CI Build #20200208.82 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing e3894d2...9c97e28
Details
codecov/project 94.65% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Feb 18, 2020
@scop

This comment has been minimized.

Copy link
Contributor

scop commented Feb 19, 2020

Interesting. I wonder if other shell scripts are similarly affected. They're not used in pre-commit checks though, but maybe in some other unixy environments on windows.

$ git grep -F /bin/sh
script/bootstrap:#!/bin/sh
script/check_format:#!/bin/sh
script/lint:#!/bin/sh
script/monkeytype:#!/bin/sh
script/release:#!/bin/sh
script/server:#!/bin/sh
script/setup:#!/bin/sh
script/test:#!/bin/sh
script/update:#!/bin/sh
tests/auth/providers/test_command_line_cmd.sh:#!/bin/sh
@balloob

This comment has been minimized.

Copy link
Member

balloob commented Feb 19, 2020

Probably are.

@lock lock bot locked and limited conversation to collaborators Feb 21, 2020
@teharris1 teharris1 deleted the teharris1:prehook branch Mar 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can鈥檛 perform that action at this time.