Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pigpio remote functionality #31667

Merged
merged 1 commit into from Feb 18, 2020
Merged

Add pigpio remote functionality #31667

merged 1 commit into from Feb 18, 2020

Conversation

@Poeschl
Copy link
Contributor

Poeschl commented Feb 9, 2020

Proposed change

This PR adds a host option to specify the host of the running pigpio daemon. This allows home-assistant to control also gpio pins on remote raspberry pi's.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
light:
  - platform: rpi_gpio_pwm
    leds:
      - name: Lightstrip Cupboard
        driver: gpio
        host: 127.0.0.1
        pins: [17]
        type: simple

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@project-bot project-bot bot added this to Needs review in Dev Feb 9, 2020
@Poeschl Poeschl mentioned this pull request Feb 9, 2020
3 of 7 tasks complete
@springstan

This comment has been minimized.

Copy link
Member

springstan commented Feb 9, 2020

@Poeschl isn't this the same as remote_rpi_gpio? 馃槃

@Poeschl

This comment has been minimized.

Copy link
Contributor Author

Poeschl commented Feb 9, 2020

As far as I looked it up, the remote_rpi_gpio toggles the pins in a binary way.
This component outputs an PWM signal on them. 馃槈

They are close and might be worth to combine in the future

@springstan

This comment has been minimized.

Copy link
Member

springstan commented Feb 9, 2020

Completely agree looking deeper into it 馃榿

@Poeschl Poeschl requested a review from springstan Feb 18, 2020
Dev automation moved this from Needs review to Reviewer approved Feb 18, 2020
@springstan springstan merged commit 0ae86b0 into home-assistant:dev Feb 18, 2020
9 checks passed
9 checks passed
CI Build #20200209.30 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Feb 18, 2020
@Poeschl Poeschl deleted the Poeschl:pigpio branch Feb 18, 2020
@lock lock bot locked and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.