Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

For vizio integration, set unique ID early to prevent multiple zeroconf discovery items for the same device to appear #31686

Merged
merged 2 commits into from Feb 10, 2020

Conversation

@raman325
Copy link
Contributor

raman325 commented Feb 10, 2020

Proposed change

Sets a unique ID early based on host during zeroconf discovery flow so that the same device isn't discovered multiple times. The unique ID will change to a serial number on ConfigEntry creation.

Config flow is new to vizio in 0.105, so this should be included in a future minor release if there is one but can wait until 0.106 if there isn't.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #31642

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
鈥he same device to appear
@project-bot project-bot bot added this to Needs review in Dev Feb 10, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Feb 10, 2020
@raman325 raman325 force-pushed the raman325:vizio_fix_discovery_dupes branch from 6153ae8 to 45a65ea Feb 10, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 10, 2020

Codecov Report

Merging #31686 into dev will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #31686   +/-   ##
=======================================
  Coverage   94.64%   94.64%           
=======================================
  Files         756      756           
  Lines       54832    54833    +1     
=======================================
+ Hits        51894    51895    +1     
  Misses       2938     2938           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 5092971...45a65ea. Read the comment docs.

Dev automation moved this from By Code Owner to Reviewer approved Feb 10, 2020
@balloob balloob merged commit 284fd46 into home-assistant:dev Feb 10, 2020
10 checks passed
10 checks passed
CI Build #20200210.20 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100.00% of diff hit (target 94.64%)
Details
codecov/project 94.64% (target 90.00%)
Details
Dev automation moved this from Reviewer approved to Done Feb 10, 2020
@raman325 raman325 deleted the raman325:vizio_fix_discovery_dupes branch Feb 11, 2020
@raman325

This comment has been minimized.

Copy link
Contributor Author

raman325 commented Feb 11, 2020

@balloob can this go out in 105.3 or did I miss the boat on that?

@raman325

This comment has been minimized.

Copy link
Contributor Author

raman325 commented Feb 11, 2020

Nevermind, I see that 105.3 was already released. This fix doesn't necessitate a new minor version but if there is a 0.105.4, it would be nice to have this included

@balloob

This comment has been minimized.

Copy link
Member

balloob commented Feb 11, 2020

Then tag it or else we'll forget.

@raman325

This comment has been minimized.

Copy link
Contributor Author

raman325 commented Feb 11, 2020

How do I do that?

@frenck frenck added this to the 0.105.4 milestone Feb 11, 2020
@lock lock bot locked and limited conversation to collaborators Feb 12, 2020
@balloob balloob removed this from the 0.105.4 milestone Feb 14, 2020
@balloob

This comment has been minimized.

Copy link
Member

balloob commented Feb 14, 2020

This PR relies on #31187, untagging it for hotfix (and now having to clean up my hotfix!)

@balloob balloob removed the cherry-picked label Feb 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can鈥檛 perform that action at this time.