Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Hue groups for new setups #31713

Merged
merged 1 commit into from Feb 11, 2020
Merged

Disable Hue groups for new setups #31713

merged 1 commit into from Feb 11, 2020

Conversation

@balloob
Copy link
Member

balloob commented Feb 10, 2020

Breaking change

Proposed change

Hue groups don't have unique IDs (#31002), hence they cannot be put in the entity registry or device registry. They are also kinda useless as Hue can be controlled via groups in Home Assistant.

So moving forward, all new set ups of Hue will disable Hue groups. They can always be enabled again via configuration.yaml.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@project-bot project-bot bot added this to Needs review in Dev Feb 10, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Feb 10, 2020
@Mariusthvdb

This comment has been minimized.

Copy link
Contributor

Mariusthvdb commented Feb 11, 2020

Hi Balloob,

wont this effect the service hue.hue_activate_scene, which needs the hue_group? Using that on a daily base here, so hardly call them useless..

  set_hue_scene:
    alias: 'Set Hue scene'
    sequence:
      service: hue.hue_activate_scene
      data_template:
        group_name: >
          {{ states('input_select.hue_groups')}}
        scene_name: >
          {{ states('input_select.hue_scenes')}}

wouldn't it be better to add the hub-id to the hue_groups? That way we could even use the groups over multiple hubs.
thanks.

@balloob

This comment has been minimized.

Copy link
Member Author

balloob commented Feb 11, 2020

No this won't impact that service, as that service uses the data directly from the API.

@balloob balloob merged commit 81b159f into dev Feb 11, 2020
11 checks passed
11 checks passed
CI Build #20200210.78 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch No report found to compare against
Details
codecov/project 94.66% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from By Code Owner to Done Feb 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the hue-default-disable-hue-groups branch Feb 11, 2020
@lock lock bot locked and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.