Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit derivative test #31717

Merged
merged 1 commit into from Feb 11, 2020
Merged

Limit derivative test #31717

merged 1 commit into from Feb 11, 2020

Conversation

@balloob
Copy link
Member

balloob commented Feb 11, 2020

Proposed change

This one derivative test took 4.74s on CI because it calculated derivates of 3600 values! 馃う鈥嶁檪

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@project-bot project-bot bot added this to Needs review in Dev Feb 11, 2020
@frenck
frenck approved these changes Feb 11, 2020
Dev automation moved this from Needs review to Reviewer approved Feb 11, 2020
@frenck frenck changed the title limit derivative test Limit derivative test Feb 11, 2020
@frenck frenck merged commit 6fcf547 into dev Feb 11, 2020
11 checks passed
11 checks passed
CI Build #20200211.9 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 5a0f21c...db2cbf9
Details
codecov/project 94.66% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Feb 11, 2020
@frenck frenck deleted the limit-derivative-test branch Feb 11, 2020
@basnijholt

This comment has been minimized.

Copy link
Contributor

basnijholt commented Feb 12, 2020

Unfortunately, the test isn't doing anything now because

if time_window < time < times[-1] - time_window:

is never met.

I will try to fix it.

basnijholt added a commit to basnijholt/home-assistant that referenced this pull request Feb 12, 2020
After home-assistant#31717 the test
didn't actually test anything anymore.

This fixes that.
@basnijholt basnijholt mentioned this pull request Feb 12, 2020
8 of 20 tasks complete
balloob pushed a commit that referenced this pull request Feb 12, 2020
* fix test_data_moving_average_for_discrete_sensor

After #31717 the test
didn't actually test anything anymore.

This fixes that.

* make the test faster
@lock lock bot locked and limited conversation to collaborators Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can鈥檛 perform that action at this time.