Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read August door open/close events from the activity log #31732

Merged

Conversation

@bdraco
Copy link
Contributor

bdraco commented Feb 11, 2020

As polling for lock status is every 15 minutes,
we read lock and unlock events from the activity log.

An upstream update of py-august was needed to
expose the door open and close events.

Door open and close events are now seen within
a few seconds instead of delayed 15+ minutes.

Breaking change

Proposed change

This is a followup to PR #31685. Support for door open/close
events was not in the original PR because an upstream update
of py-august was required in order to support them

Read door open/close events from the activity log.

As polling for lock status is every 15 minutes,
we read lock and unlock events from the activity log.

An upstream update of py-august was needed to
expose the door open and close events.

Door open and close events are now seen within
a few seconds instead of delayed 15+ minutes.

Bump py-august to 0.11.0

As soon as this one is worked out, I have few to submit on top of this.

  • Add automatic token refresh support (no more relogin every 6 months)
  • Some general refactoring and tests (since this module needs a bit of love in that area)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@project-bot project-bot bot added this to Needs review in Dev Feb 11, 2020
As polling for lock status is every 15 minutes,
we read lock and unlock events from the activity log.

An upstream update of py-august was needed to
expose the door open and close events.

Door open and close events are now seen within
a few seconds instead of delayed 15+ minutes.
@bdraco bdraco force-pushed the bdraco:read_doorsense_events_from_activity_log branch from 23f7f86 to 9a884c2 Feb 11, 2020
@bdraco bdraco requested a review from MartinHjelmare Feb 11, 2020
@bdraco bdraco mentioned this pull request Feb 11, 2020
9 of 20 tasks complete
@MartinHjelmare MartinHjelmare changed the title Read door open/close events from the activity log. Read August door open/close events from the activity log Feb 11, 2020
Dev automation moved this from Needs review to Reviewer approved Feb 12, 2020
@balloob balloob merged commit 54eb740 into home-assistant:dev Feb 12, 2020
10 checks passed
10 checks passed
CI Build #20200211.37 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 81b159f...9a884c2
Details
codecov/project 94.66% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Feb 12, 2020
@lock lock bot locked and limited conversation to collaborators Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.