Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh the august access token when needed #31735

Merged
merged 3 commits into from Feb 12, 2020

Conversation

@bdraco
Copy link
Contributor

bdraco commented Feb 11, 2020

Breaking change

Proposed change

Currently august will stop working when the token
expires about every six month.

This fixes #23788

Also in review #31732 (please review this one first)
Next up:

  • Some general refactoring and tests (since this module needs a bit of love in that area)
  • Fixes for the doorbell code (I had to buy one before could start working through these issues)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #23788
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #31735 into dev will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #31735   +/-   ##
=======================================
  Coverage   94.65%   94.66%           
=======================================
  Files         762      762           
  Lines       55029    55029           
=======================================
+ Hits        52090    52092    +2     
+ Misses       2939     2937    -2     
Impacted Files Coverage 螖
homeassistant/helpers/entity.py 97.26% <0.00%> (-0.35%) 猬囷笍
homeassistant/components/template/cover.py 97.71% <0.00%> (+1.36%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 51c35ab...3e907f8. Read the comment docs.

@bdraco bdraco requested a review from MartinHjelmare Feb 11, 2020
@MartinHjelmare MartinHjelmare changed the title Refresh the august access token when needed. Refresh the august access token when needed Feb 11, 2020
@balloob

This comment has been minimized.

Copy link
Member

balloob commented Feb 12, 2020

Nice work on all this. Can you please add yourself as a code owner in the manifest and run python3 -m script.hassfest.

@bdraco

This comment has been minimized.

Copy link
Contributor Author

bdraco commented Feb 12, 2020

Nice work on all this. Can you please add yourself as a code owner in the manifest and run python3 -m script.hassfest.

Will do in the next resubmit

@bdraco bdraco requested review from cgtobi, dgomes and scop as code owners Feb 12, 2020
when needed.

Currently august will stop working when the token
expires about every six month.

This resolves issue #23788
@bdraco bdraco force-pushed the bdraco:refresh_august_token_when_needed branch from f3e184e to 3d5eb0b Feb 12, 2020
@bdraco

This comment has been minimized.

Copy link
Contributor Author

bdraco commented Feb 12, 2020

Apologizes for the extra commits. I'm still getting used to the github workflow.

bdraco added 2 commits Feb 12, 2020
@bdraco bdraco requested a review from balloob Feb 12, 2020
Copy link
Member

balloob left a comment

馃帀 nice!

Dev automation moved this from Needs review to Reviewer approved Feb 12, 2020
@balloob balloob merged commit f5be9ef into home-assistant:dev Feb 12, 2020
10 checks passed
10 checks passed
CI Build #20200212.12 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 891f13e...ef160c7
Details
codecov/project 94.65% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Feb 12, 2020
@bdraco bdraco deleted the bdraco:refresh_august_token_when_needed branch Feb 13, 2020
@lock lock bot locked and limited conversation to collaborators Feb 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can鈥檛 perform that action at this time.