Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZHA tests refactoring #31744

Merged
merged 14 commits into from Feb 12, 2020
Merged

ZHA tests refactoring #31744

merged 14 commits into from Feb 12, 2020

Conversation

@Adminiuga
Copy link
Contributor

Adminiuga commented Feb 12, 2020

Breaking change

No

Proposed change

Address comment to #31682. Patch radio modules in tests instead of ZHA code.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
Adminiuga added 12 commits Feb 11, 2020
Patch Zigpy radio libs instead of ZHA when setting up fixtures.
Use new fixtures for binary_sensor.zha platform.
@project-bot project-bot bot added this to Needs review in Dev Feb 12, 2020
@Adminiuga Adminiuga requested a review from dmulcahey Feb 12, 2020
@Adminiuga Adminiuga mentioned this pull request Feb 12, 2020
7 of 20 tasks complete
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Feb 12, 2020

Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as its been labeled with a integration (zha) you are listed as a codeowner for? Thanks!

tests/components/zha/conftest.py Outdated Show resolved Hide resolved
tests/components/zha/conftest.py Outdated Show resolved Hide resolved
tests/components/zha/conftest.py Show resolved Hide resolved
tests/components/zha/conftest.py Outdated Show resolved Hide resolved
tests/components/zha/conftest.py Outdated Show resolved Hide resolved
Adminiuga added 2 commits Feb 12, 2020
Dev automation moved this from Needs review to Reviewer approved Feb 12, 2020
Copy link
Member

MartinHjelmare left a comment

Nice!

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #31744 into dev will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #31744      +/-   ##
==========================================
+ Coverage   94.65%   94.66%   +0.01%     
==========================================
  Files         762      763       +1     
  Lines       55014    55114     +100     
==========================================
+ Hits        52074    52176     +102     
+ Misses       2940     2938       -2     
Impacted Files Coverage 螖
...tant/components/homematicip_cloud/binary_sensor.py 99.54% <0.00%> (-0.46%) 猬囷笍
homeassistant/components/config/entity_registry.py 89.65% <0.00%> (-0.18%) 猬囷笍
homeassistant/components/hue/const.py 100.00% <0.00%> (酶) 猬嗭笍
homeassistant/components/plex/const.py 100.00% <0.00%> (酶) 猬嗭笍
homeassistant/helpers/entity_platform.py 95.59% <0.00%> (酶) 猬嗭笍
homeassistant/components/hue/config_flow.py 96.84% <0.00%> (酶) 猬嗭笍
...eassistant/components/websocket_api/permissions.py 100.00% <0.00%> (酶) 猬嗭笍
homeassistant/components/vilfo/config_flow.py 100.00% <0.00%> (酶)
homeassistant/helpers/entity_registry.py 99.53% <0.00%> (+0.02%) 猬嗭笍
homeassistant/helpers/entity.py 97.60% <0.00%> (+0.02%) 猬嗭笍
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update c66106e...1198030. Read the comment docs.

@Adminiuga Adminiuga merged commit 52fe132 into home-assistant:dev Feb 12, 2020
10 checks passed
10 checks passed
CI Build #20200212.57 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing c66106e...1198030
Details
codecov/project 94.66% (target 90.00%)
Details
Dev automation moved this from Reviewer approved to Done Feb 12, 2020
@Adminiuga Adminiuga deleted the Adminiuga:ac/zha-tests-2 branch Feb 12, 2020
@lock lock bot locked and limited conversation to collaborators Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can鈥檛 perform that action at this time.