Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix moving average test for discrete derivative sensor #31750

Merged
merged 2 commits into from Feb 12, 2020

Conversation

@basnijholt
Copy link
Contributor

basnijholt commented Feb 12, 2020

After #31717, this test didn't actually test anything anymore because time_window < time < times[-1] - time_window was never true.

This fixes that.

It's a loop of 60 now (vs 3600 before), is that acceptable?

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
After #31717 the test
didn't actually test anything anymore.

This fixes that.
@project-bot project-bot bot added this to Needs review in Dev Feb 12, 2020
@basnijholt basnijholt requested a review from balloob Feb 12, 2020
@MartinHjelmare MartinHjelmare changed the title fix test_data_moving_average_for_discrete_sensor Fix moving average test for discrete derivative sensor Feb 12, 2020
Dev automation moved this from Needs review to Reviewer approved Feb 12, 2020
Copy link
Member

balloob left a comment

Looks like it hasn't showed back up again on the longest durations. So great ! 馃帀

5.71s teardown tests/components/default_config/test_init.py::test_setup[pyloop]
3.38s call     tests/components/owntracks/test_device_tracker.py::test_mobile_multiple_async_enter_exit[pyloop]
2.95s call     tests/components/zha/test_light.py::test_light[zha_device_joined-pyloop-device2-reporting2]
2.44s call     tests/components/verisure/test_lock.py::test_verisure_default_code[pyloop]
1.79s call     tests/components/zha/test_device_tracker.py::test_device_tracker[zha_device_joined-pyloop]
1.65s call     tests/auth/providers/test_homeassistant.py::test_legacy_saving_loading[pyloop]
1.64s teardown tests/components/gdacs/test_config_flow.py::test_step_import[pyloop]
1.58s teardown tests/components/gdacs/test_config_flow.py::test_step_user[pyloop]
1.46s call     tests/components/verisure/test_lock.py::test_verisure_no_default_code[pyloop]
1.43s call     tests/components/homematicip_cloud/test_config_flow.py::test_flow_works[pyloop]
@balloob balloob merged commit 8498ca3 into home-assistant:dev Feb 12, 2020
8 checks passed
8 checks passed
CI Build #20200212.23 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
Dev automation moved this from Reviewer approved to Done Feb 12, 2020
@lock lock bot locked and limited conversation to collaborators Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.