Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

UniFi config option SSID filter #31842

Merged
merged 7 commits into from Feb 18, 2020

Conversation

@Kane610
Copy link
Member

Kane610 commented Feb 15, 2020

Breaking change

Proposed change

Allow SSID filter be set from config options, to help control what SSIDs wireless clients will be tracked on.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue: depends on home-assistant/frontend#4247
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@Kane610 Kane610 self-assigned this Feb 15, 2020
@project-bot project-bot bot added this to Needs review in Dev Feb 15, 2020
@Kane610 Kane610 force-pushed the Kane610:unifi-config_option_ssid_filter branch from 6f20b59 to 9ceb21f Feb 16, 2020
@Kane610 Kane610 marked this pull request as ready for review Feb 16, 2020
@Kane610

This comment has been minimized.

Copy link
Member Author

Kane610 commented Feb 16, 2020

This is ready for review, but I'd like to verify against the frontend PR before merging

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 16, 2020

Codecov Report

Merging #31842 into dev will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #31842      +/-   ##
==========================================
- Coverage   94.69%   94.67%   -0.02%     
==========================================
  Files         763      764       +1     
  Lines       55210    55388     +178     
==========================================
+ Hits        52279    52440     +161     
- Misses       2931     2948      +17     
Impacted Files Coverage 螖
homeassistant/components/demo/config_flow.py 62.85% <0.00%> (-37.15%) 猬囷笍
homeassistant/util/logging.py 95.83% <0.00%> (-1.61%) 猬囷笍
homeassistant/helpers/entity_registry.py 99.53% <0.00%> (酶) 猬嗭笍
homeassistant/components/deconz/climate.py 100.00% <0.00%> (酶) 猬嗭笍
homeassistant/components/deconz/gateway.py 100.00% <0.00%> (酶) 猬嗭笍
homeassistant/components/deconz/binary_sensor.py 98.03% <0.00%> (酶) 猬嗭笍
homeassistant/components/twitch/sensor.py 96.73% <0.00%> (酶)
homeassistant/components/deconz/deconz_device.py 94.44% <0.00%> (+0.56%) 猬嗭笍
homeassistant/components/deconz/sensor.py 96.82% <0.00%> (+0.79%) 猬嗭笍
homeassistant/bootstrap.py 75.40% <0.00%> (+2.62%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update a6b5d73...89e8e85. Read the comment docs.

Kane610 added 3 commits Oct 14, 2019
@Kane610 Kane610 force-pushed the Kane610:unifi-config_option_ssid_filter branch from 2ef357d to a996192 Feb 17, 2020
@Kane610

This comment has been minimized.

Copy link
Member Author

Kane610 commented Feb 17, 2020

Verified and ready to go!

Kane610 added 2 commits Feb 18, 2020
Copy link
Member

MartinHjelmare left a comment

Looks good!

Dev automation moved this from Needs review to Reviewer approved Feb 18, 2020
@Kane610 Kane610 mentioned this pull request Feb 18, 2020
8 of 20 tasks complete
@Kane610 Kane610 merged commit 774c892 into home-assistant:dev Feb 18, 2020
10 checks passed
10 checks passed
CI Build #20200218.73 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100.00% of diff hit (target 94.69%)
Details
codecov/project 94.67% (target 90.00%)
Details
Dev automation moved this from Reviewer approved to Done Feb 18, 2020
@Kane610 Kane610 deleted the Kane610:unifi-config_option_ssid_filter branch Feb 18, 2020
@lock lock bot locked and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can鈥檛 perform that action at this time.