Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump adafruit-blinka and adafruit-circuitpython-mcp230xx #31845

Merged
merged 2 commits into from Feb 16, 2020

Conversation

@jardiamj
Copy link
Contributor

jardiamj commented Feb 15, 2020

鈥dafruit_CircuitPython_MCP230xx v-2.2.2

Proposed change

This PR updates the mcp23017 integration to use the latest adafruit-blinka (v-3.9.0) and Adafruit_CircuitPython_MCP230xx (v-2.2.2) libraries.
It fixes issues caused by the code refactoring of the Adafruit_Python_PlatformDetect library.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #31719
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
jardiamj added 2 commits Feb 15, 2020
鈥dafruit_CircuitPython_MCP230xx v-2.2.2
@project-bot project-bot bot added this to Needs review in Dev Feb 15, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Feb 15, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 15, 2020

Codecov Report

Merging #31845 into dev will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #31845      +/-   ##
==========================================
+ Coverage   94.65%   94.66%   +<.01%     
==========================================
  Files         763      763              
  Lines       55152    55170      +18     
==========================================
+ Hits        52204    52226      +22     
+ Misses       2948     2944       -4
Impacted Files Coverage 螖
homeassistant/components/ipma/config_flow.py 100% <0%> (酶) 猬嗭笍
...stant/components/homekit_controller/config_flow.py 100% <0%> (酶) 猬嗭笍
...ssistant/components/google_assistant/smart_home.py 91.2% <0%> (酶) 猬嗭笍
homeassistant/components/coolmaster/config_flow.py 100% <0%> (酶) 猬嗭笍
homeassistant/components/esphome/config_flow.py 100% <0%> (酶) 猬嗭笍
homeassistant/components/google_assistant/const.py 100% <0%> (酶) 猬嗭笍
homeassistant/helpers/restore_state.py 98.44% <0%> (+0.01%) 猬嗭笍
homeassistant/helpers/entity_component.py 96.82% <0%> (+0.02%) 猬嗭笍
homeassistant/helpers/collection.py 95.58% <0%> (+0.04%) 猬嗭笍
...meassistant/components/google_assistant/helpers.py 93.87% <0%> (+0.07%) 猬嗭笍
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 9eb0415...b7e0947. Read the comment docs.

Copy link
Member

springstan left a comment

LGTM 鉁

Dev automation moved this from By Code Owner to Reviewer approved Feb 15, 2020
@springstan springstan changed the title Update mcp23017 Bump adafruit-blinka and adafruit-circuitpython-mcp230xx Feb 16, 2020
@springstan springstan merged commit 6be0bcc into home-assistant:dev Feb 16, 2020
11 checks passed
11 checks passed
CI Build #20200215.12 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 9eb0415...b7e0947
Details
codecov/project 94.66% (+<.01%) compared to 9eb0415
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Feb 16, 2020
@lock lock bot locked and limited conversation to collaborators Feb 17, 2020
@jardiamj jardiamj deleted the jardiamj:update-mcp23017 branch Feb 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can鈥檛 perform that action at this time.