Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert august to async so a token refresh lock can be used #31848

Merged

Conversation

@bdraco
Copy link
Contributor

bdraco commented Feb 15, 2020

Breaking change

Proposed change

This is a followup to #31735 to address the concern @balloob raised about having a lock to refresh the token. This was deferred as the size of the work to do this exceeded the previous pull request.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@project-bot project-bot bot added this to Needs review in Dev Feb 15, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Feb 15, 2020
bdraco added 2 commits Feb 15, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 15, 2020

Codecov Report

鉂楋笍 No coverage uploaded for pull request base (dev@f3a8196). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev   #31848   +/-   ##
======================================
  Coverage       ?   94.65%           
======================================
  Files          ?      763           
  Lines          ?    55175           
  Branches       ?        0           
======================================
  Hits           ?    52227           
  Misses         ?     2948           
  Partials       ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update f3a8196...a622ddf. Read the comment docs.

@bdraco

This comment has been minimized.

Copy link
Contributor Author

bdraco commented Feb 15, 2020

@balloob This should hopefully, better address the concern you raised in #31735 about having an async lock for the token update. I'm still looking into DataUpdateCoordinator for a followup PR.

@bdraco bdraco requested a review from balloob Feb 15, 2020
@balloob

This comment has been minimized.

Copy link
Member

balloob commented Feb 15, 2020

Looks good! Had a few tiny comments.

@bdraco bdraco mentioned this pull request Feb 16, 2020
9 of 20 tasks complete
Dev automation moved this from By Code Owner to Reviewer approved Feb 16, 2020
Copy link
Member

balloob left a comment

馃帀

@balloob balloob merged commit f6d9e6b into home-assistant:dev Feb 16, 2020
10 checks passed
10 checks passed
CI Build #20200216.3 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected.
Details
codecov/project No report found to compare against
Details
Dev automation moved this from Reviewer approved to Done Feb 16, 2020
@lock lock bot locked and limited conversation to collaborators Feb 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.