Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up netgear device tracker #31861

merged 7 commits into from Feb 16, 2020

Clean up netgear device tracker #31861

merged 7 commits into from Feb 16, 2020


Copy link

MartinHjelmare commented Feb 15, 2020

Breaking change

Proposed change

Clean up the netgear device tracker platform.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
  - platform: netgear
    host: REDACTED
    password: REDACTED

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:


  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@MartinHjelmare MartinHjelmare force-pushed the clean-netgear branch from eef2975 to 96b1392 Feb 15, 2020

This comment was marked as off-topic.

Copy link

codecov bot commented Feb 15, 2020

Codecov Report

Merging #31861 into dev will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #31861      +/-   ##
+ Coverage   94.65%   94.69%   +0.03%     
  Files         763      763              
  Lines       55170    55192      +22     
+ Hits        52223    52264      +41     
+ Misses       2947     2928      -19
Impacted Files Coverage 螖
homeassistant/helpers/ 98.44% <0%> (酶) 猬嗭笍
homeassistant/components/mikrotik/ 100% <0%> (酶) 猬嗭笍
homeassistant/helpers/ 99.81% <0%> (酶) 猬嗭笍
homeassistant/components/jewish_calendar/ 97.87% <0%> (+0.04%) 猬嗭笍
homeassistant/components/config/ 85.23% <0%> (+0.09%) 猬嗭笍
homeassistant/components/rest/ 99.28% <0%> (+0.1%) 猬嗭笍
homeassistant/components/homematicip_cloud/ 85.06% <0%> (+0.29%) 猬嗭笍
homeassistant/helpers/ 97.61% <0%> (+0.34%) 猬嗭笍
...tant/components/homematicip_cloud/ 100% <0%> (+0.45%) 猬嗭笍
homeassistant/helpers/ 71.18% <0%> (+0.49%) 猬嗭笍
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 588f2cd...df85fa4. Read the comment docs.

Dev automation moved this from Needs review to Reviewer approved Feb 15, 2020
@springstan springstan merged commit f53ae12 into dev Feb 16, 2020
10 checks passed
10 checks passed
CI Build #20200216.45 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 588f2cd...df85fa4
codecov/project 94.69% (+0.03%) compared to 588f2cd
Dev automation moved this from Reviewer approved to Done Feb 16, 2020
@delete-merged-branch delete-merged-branch bot deleted the clean-netgear branch Feb 16, 2020
@lock lock bot locked and limited conversation to collaborators Feb 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can鈥檛 perform that action at this time.