Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve media name detection on lg_netcast #31863

merged 1 commit into from Feb 15, 2020


Copy link

maxcanna commented Feb 15, 2020

Proposed change

When the tv is using an external input (e.g. HDMI1) values have to be taken from other fields otherwise they'll empty

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

  - platform: lg_netcast
    name: LGigi
    access_token: 123456

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:


  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
When the tv is using an external input (e.g. HDMI1) values have to be taken from fields otherwise they'll empty

This comment has been minimized.

Copy link

codecov bot commented Feb 15, 2020

Codecov Report

Merging #31863 into dev will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #31863   +/-   ##
  Coverage   94.65%   94.66%           
  Files         763      763           
  Lines       55170    55170           
+ Hits        52223    52227    +4     
+ Misses       2947     2943    -4     
Impacted Files Coverage 螖
homeassistant/helpers/ 97.61% <0.00%> (+0.34%) 猬嗭笍
homeassistant/components/template/ 97.71% <0.00%> (+1.36%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 588f2cd...b928d17. Read the comment docs.

Copy link

balloob left a comment


Dev automation moved this from Needs review to Reviewer approved Feb 15, 2020
@balloob balloob merged commit 2c42e2a into home-assistant:dev Feb 15, 2020
11 checks passed
11 checks passed
CI Build #20200215.50 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 588f2cd...b928d17
codecov/project 94.66% (target 90.00%)
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Feb 15, 2020
@lock lock bot locked and limited conversation to collaborators Feb 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.