Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent config_name being assigned from initial dev_id/host_name #31886

Merged
merged 1 commit into from Feb 17, 2020

Conversation

@mueslo
Copy link
Contributor

mueslo commented Feb 16, 2020

Breaking change

Proposed change

Changes device_tracker legacy module behaviour. Previously when a device was first seen it would set config_name to host_name or dev_id, whichever is available. However, this is a bad design due to data duplication. This information can be extracted when the Device.name property is evaluated. Additionally, now also only overwrite the saved hostname if it is non-empty.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

Unchanged

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@project-bot project-bot bot added this to Needs review in Dev Feb 16, 2020
@mueslo mueslo changed the title prevent dev_id being permanently assigned as config_name device_tracker: Prevent config_name being assigned from initial dev_id/host_name Feb 16, 2020
@mueslo mueslo changed the title device_tracker: Prevent config_name being assigned from initial dev_id/host_name Prevent config_name being assigned from initial dev_id/host_name Feb 16, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 16, 2020

Codecov Report

Merging #31886 into dev will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #31886      +/-   ##
==========================================
+ Coverage   94.65%   94.68%   +0.03%     
==========================================
  Files         763      763              
  Lines       55170    55192      +22     
==========================================
+ Hits        52223    52261      +38     
+ Misses       2947     2931      -16     
Impacted Files Coverage 螖
homeassistant/helpers/restore_state.py 98.44% <0.00%> (酶) 猬嗭笍
homeassistant/components/mikrotik/const.py 100.00% <0.00%> (酶) 猬嗭笍
homeassistant/helpers/template.py 99.81% <0.00%> (+<0.01%) 猬嗭笍
homeassistant/components/jewish_calendar/sensor.py 97.87% <0.00%> (+0.04%) 猬嗭笍
homeassistant/components/config/config_entries.py 85.23% <0.00%> (+0.09%) 猬嗭笍
homeassistant/components/rest/sensor.py 99.28% <0.00%> (+0.10%) 猬嗭笍
homeassistant/components/homematicip_cloud/hap.py 85.06% <0.00%> (+0.29%) 猬嗭笍
homeassistant/helpers/entity.py 97.61% <0.00%> (+0.34%) 猬嗭笍
...tant/components/homematicip_cloud/binary_sensor.py 100.00% <0.00%> (+0.45%) 猬嗭笍
homeassistant/helpers/data_entry_flow.py 71.18% <0.00%> (+0.49%) 猬嗭笍
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 588f2cd...b15a416. Read the comment docs.

Dev automation moved this from Needs review to Reviewer approved Feb 17, 2020
@balloob balloob merged commit 00b3efe into home-assistant:dev Feb 17, 2020
11 checks passed
11 checks passed
CI Build #20200216.31 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100.00% of diff hit (target 94.65%)
Details
codecov/project 94.68% (target 90.00%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Feb 17, 2020
@lock lock bot locked and limited conversation to collaborators Feb 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.