Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade greeneye_monitor to 2.0 #31896

Merged
merged 1 commit into from Feb 17, 2020
Merged

Conversation

@jkeljo
Copy link
Contributor

jkeljo commented Feb 17, 2020

Breaking change

Greeneye Monitor temperature readings are now correct (previously they would report as twice the actual value). If you've compensated for this in your dashboards or displays, you'll need to undo that compensation with this release.

Proposed change

Upgrades to v2.0 of the greeneye_monitor package, picking up a bug fix which is also a breaking change (see above).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue: jkeljo/greeneye-monitor#3
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 17, 2020

Codecov Report

Merging #31896 into dev will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #31896      +/-   ##
==========================================
+ Coverage   94.68%   94.69%   +<.01%     
==========================================
  Files         763      763              
  Lines       55192    55181      -11     
==========================================
- Hits        52261    52253       -8     
+ Misses       2931     2928       -3
Impacted Files Coverage 螖
homeassistant/components/uk_transport/sensor.py 93.47% <0%> (-0.73%) 猬囷笍
...omeassistant/components/soundtouch/media_player.py 100% <0%> (酶) 猬嗭笍
...ssistant/components/islamic_prayer_times/sensor.py 95.74% <0%> (+1.06%) 猬嗭笍
homeassistant/components/template/cover.py 97.71% <0%> (+1.36%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update ae78fb8...45dd760. Read the comment docs.

@balloob balloob merged commit 56142ba into home-assistant:dev Feb 17, 2020
11 checks passed
11 checks passed
CI Build #20200217.1 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 9f376a9...45dd760
Details
codecov/project 94.69% (+<.01%) compared to 9f376a9
Details
docs-missing Documentation ok.
Dev automation moved this from By Code Owner to Done Feb 17, 2020
@lock lock bot locked and limited conversation to collaborators Feb 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.