Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying an icon for a scene #31898

Merged
merged 1 commit into from Feb 17, 2020
Merged

Allow specifying an icon for a scene #31898

merged 1 commit into from Feb 17, 2020

Conversation

@balloob
Copy link
Member

balloob commented Feb 17, 2020

Breaking change

Proposed change

Add a new icon configuration parameter to specify an icon for a scene.

Also realized ID was missing from config validation, added it.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@balloob balloob requested a review from home-assistant/core as a code owner Feb 17, 2020
@project-bot project-bot bot added this to Needs review in Dev Feb 17, 2020
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Feb 17, 2020

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (homeassistant) you are listed as a codeowner for? Thanks!

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 17, 2020

Codecov Report

Merging #31898 into dev will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #31898      +/-   ##
==========================================
- Coverage   94.69%   94.68%   -0.01%     
==========================================
  Files         763      763              
  Lines       55181    55183       +2     
==========================================
- Hits        52252    52251       -1     
- Misses       2929     2932       +3
Impacted Files Coverage 螖
homeassistant/components/homeassistant/scene.py 93.89% <100%> (+0.09%) 猬嗭笍
homeassistant/components/template/cover.py 96.34% <0%> (-1.37%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 56142ba...137a2e7. Read the comment docs.

@frenck
frenck approved these changes Feb 17, 2020
Dev automation moved this from Needs review to Reviewer approved Feb 17, 2020
@balloob balloob merged commit c788946 into dev Feb 17, 2020
11 checks passed
11 checks passed
CI Build #20200217.8 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.69%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +5.3% compared to f30c636
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Feb 17, 2020
@balloob balloob deleted the icon-scene branch Feb 17, 2020
@balloob balloob mentioned this pull request Feb 17, 2020
1 of 7 tasks complete
@lock lock bot locked and limited conversation to collaborators Feb 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.