Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove duke_energy integration (ADR-0004) #31921
The Duke Energy integration has been removed. The website of Duke Energy changed, causing the integration to break because it relied on web scraping. This integration should have been removed before as per ADR-0004.
This PR removes the Duke Energy integration. The website of Duke Energy changed, causing the integration to break. This integration should have been removed before as per ADR-0004.
Type of change
Example entry for
@@ Coverage Diff @@ ## dev #31921 +/- ## ========================================== + Coverage 94.69% 94.69% +<.01% ========================================== Files 763 763 Lines 55210 55210 ========================================== + Hits 52279 52281 +2 + Misses 2931 2929 -2
@frenck I am the original creator of this integration and have been looking at it recently. The web scraping part was just a way to help the user, isn't a requirement for this to work. The scrap grabbed the ID of the meter in order to call the REST api with the correct details. We could make a change to allow users to manually provide that ID via YAML.
Having said that, I started working on that and noticed that there are errors when calling the API that result in SSL certificate errors. I reached out on the dev discord and no one responded, but basically this issue w1ll1am23/pydukeenergy#2 is what is holding me up.
If I ignore SSL in requests everything works, but I am not sure why that is occurring. As it use to work, did something with SSL chance in newer version of Python? The site works in a browser and the cert is valid.
Would you be able to assist me in finding out what is causing this SSL issues?