Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duke_energy integration (ADR-0004) #31921

Merged
merged 1 commit into from Feb 17, 2020
Merged

Remove duke_energy integration (ADR-0004) #31921

merged 1 commit into from Feb 17, 2020

Conversation

@frenck
Copy link
Member

frenck commented Feb 17, 2020

Breaking change

The Duke Energy integration has been removed. The website of Duke Energy changed, causing the integration to break because it relied on web scraping. This integration should have been removed before as per ADR-0004.

Proposed change

This PR removes the Duke Energy integration. The website of Duke Energy changed, causing the integration to break. This integration should have been removed before as per ADR-0004.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@project-bot project-bot bot added this to Needs review in Dev Feb 17, 2020
@frenck frenck mentioned this pull request Feb 17, 2020
3 of 7 tasks complete
@frenck frenck marked this pull request as ready for review Feb 17, 2020
Dev automation moved this from Needs review to Reviewer approved Feb 17, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 17, 2020

Codecov Report

Merging #31921 into dev will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #31921      +/-   ##
==========================================
+ Coverage   94.69%   94.69%   +<.01%     
==========================================
  Files         763      763              
  Lines       55210    55210              
==========================================
+ Hits        52279    52281       +2     
+ Misses       2931     2929       -2
Impacted Files Coverage 螖
homeassistant/helpers/entity.py 97.27% <0%> (-0.35%) 猬囷笍
homeassistant/components/template/cover.py 97.71% <0%> (+1.36%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update a6b5d73...1701010. Read the comment docs.

@frenck frenck merged commit 4497e98 into dev Feb 17, 2020
11 checks passed
11 checks passed
CI Build #20200217.70 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing a6b5d73...1701010
Details
codecov/project 94.69% (+<.01%) compared to a6b5d73
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Feb 17, 2020
@frenck frenck deleted the frenck-2020-0201 branch Feb 17, 2020
@lock lock bot locked and limited conversation to collaborators Feb 21, 2020
@w1ll1am23

This comment has been minimized.

Copy link
Collaborator

w1ll1am23 commented Feb 26, 2020

@frenck I am the original creator of this integration and have been looking at it recently. The web scraping part was just a way to help the user, isn't a requirement for this to work. The scrap grabbed the ID of the meter in order to call the REST api with the correct details. We could make a change to allow users to manually provide that ID via YAML.

Having said that, I started working on that and noticed that there are errors when calling the API that result in SSL certificate errors. I reached out on the dev discord and no one responded, but basically this issue w1ll1am23/pydukeenergy#2 is what is holding me up.

If I ignore SSL in requests everything works, but I am not sure why that is occurring. As it use to work, did something with SSL chance in newer version of Python? The site works in a browser and the cert is valid.

Would you be able to assist me in finding out what is causing this SSL issues?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can鈥檛 perform that action at this time.