Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aio_geojson_nsw_rfs_incidents to 0.3 #31941

Merged

Conversation

@exxamalte
Copy link
Contributor

exxamalte commented Feb 18, 2020

Breaking change

Proposed change

Update integration library aio_geojson_nsw_rfs_incidents to version 0.3. This is used by the NSW Rural Fire Service Incidents integration.
The upstream library (aio_geojson_client version 0.13) contains a bugfix for properly handling GeoJSON polygons contained in the feed the integration uses.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
geo_location:
  - platform: nsw_rural_fire_service_feed

Additional information

  • This PR fixes or closes issue: fixes #31938
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@project-bot project-bot bot added this to Needs review in Dev Feb 18, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Feb 18, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #31941 into dev will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #31941      +/-   ##
==========================================
- Coverage   94.68%   94.67%   -0.02%     
==========================================
  Files         763      763              
  Lines       55181    55239      +58     
==========================================
+ Hits        52249    52295      +46     
- Misses       2932     2944      +12
Impacted Files Coverage 螖
homeassistant/components/demo/config_flow.py 62.85% <0%> (-37.15%) 猬囷笍
script/__init__.py 96.55% <0%> (酶) 猬嗭笍
homeassistant/components/homeassistant/scene.py 93.89% <0%> (+0.09%) 猬嗭笍
homeassistant/bootstrap.py 72.78% <0%> (+0.16%) 猬嗭笍
homeassistant/helpers/entity.py 97.61% <0%> (+0.34%) 猬嗭笍
homeassistant/util/json.py 85.71% <0%> (+8.44%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update aead5ba...4b1a1c3. Read the comment docs.

Dev automation moved this from By Code Owner to Reviewer approved Feb 18, 2020
@springstan springstan merged commit e65995e into home-assistant:dev Feb 18, 2020
11 checks passed
11 checks passed
CI Build #20200218.7 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing aead5ba...4b1a1c3
Details
codecov/project Absolute coverage decreased by -0.02, only covered lines were removed
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Feb 18, 2020
@exxamalte exxamalte deleted the exxamalte:update-aio-geojson-nsw-rfs-incidents branch Feb 18, 2020
@lock lock bot locked and limited conversation to collaborators Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can鈥檛 perform that action at this time.