Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translations_develop #31942

Merged
merged 1 commit into from Feb 18, 2020
Merged

Fix translations_develop #31942

merged 1 commit into from Feb 18, 2020

Conversation

@austinmroczek
Copy link
Contributor

austinmroczek commented Feb 18, 2020

Proposed change

The translations_develop script was failing to create the 'translations-download' directory because the parent directory 'build' was not there.

This adds parents=True to the mkdir() call.

Per https://docs.python.org/3/library/pathlib.html
If parents is true, any missing parents of this path are created as needed;

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

This was discussed on discord dev channel by @issacg and @balloob on 2/16.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • [n/a] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [n/a] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [n/a] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [n/a] Untested files have been added to .coveragerc.
@project-bot project-bot bot added this to Needs review in Dev Feb 18, 2020
Dev automation moved this from Needs review to Reviewer approved Feb 18, 2020
Copy link
Member

balloob left a comment

🎉🎉 good catch. Great PR!

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #31942 into dev will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #31942      +/-   ##
==========================================
+ Coverage   94.67%   94.67%   +<.01%     
==========================================
  Files         763      763              
  Lines       55239    55239              
==========================================
+ Hits        52295    52298       +3     
+ Misses       2944     2941       -3
Impacted Files Coverage Δ
...ssistant/components/islamic_prayer_times/sensor.py 94.68% <0%> (-1.07%) ⬇️
homeassistant/components/uk_transport/sensor.py 94.2% <0%> (+0.72%) ⬆️
homeassistant/components/template/cover.py 97.71% <0%> (+1.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e51619...9b940df. Read the comment docs.

@springstan springstan merged commit 1fa16ee into home-assistant:dev Feb 18, 2020
11 checks passed
11 checks passed
CI Build #20200218.9 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 70910ec...9b940df
Details
codecov/project 94.67% (+<.01%) compared to 70910ec
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Feb 18, 2020
@lock lock bot locked and limited conversation to collaborators Feb 22, 2020
@austinmroczek austinmroczek deleted the austinmroczek:fix-script branch Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.