Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read Modbus climate current temp from input register #31944

Merged

Conversation

@vzahradnik
Copy link
Contributor

vzahradnik commented Feb 18, 2020

Proposed change

This change adds a new optional parameter current_temp_register_type into Modbus climate to allow reading values from both input registers (read-only) and holding registers (read and write). Because current temperature is always read and never written, it makes sense to allow such an option.

This change was manually tested.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
climate:
  - platform: modbus
    name: Watlow F4T
    hub: hub1
    slave: 1
    data_type: uint
    target_temp_register: 2782
    current_temp_register: 27586
    current_temp_register_type: input

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Feb 18, 2020

Hey there @adamchengtkc, mind taking a look at this pull request as its been labeled with a integration (modbus) you are listed as a codeowner for? Thanks!

@vzahradnik vzahradnik mentioned this pull request Feb 18, 2020
3 of 7 tasks complete
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #31944 into dev will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #31944      +/-   ##
==========================================
+ Coverage   94.67%   94.67%   +<.01%     
==========================================
  Files         763      763              
  Lines       55239    55239              
==========================================
+ Hits        52295    52298       +3     
+ Misses       2944     2941       -3
Impacted Files Coverage 螖
...ssistant/components/islamic_prayer_times/sensor.py 94.68% <0%> (-1.07%) 猬囷笍
homeassistant/helpers/entity_registry.py 99.53% <0%> (酶) 猬嗭笍
homeassistant/components/uk_transport/sensor.py 94.2% <0%> (+0.72%) 猬嗭笍
homeassistant/components/template/cover.py 97.71% <0%> (+1.36%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 2e51619...054c352. Read the comment docs.

@springstan springstan moved this from Needs review to Review in progress in Dev Feb 18, 2020
@vzahradnik vzahradnik force-pushed the vzahradnik:feature/modbus-climate-register-type branch from c435ea9 to 64611dd Feb 18, 2020
Copy link
Member

springstan left a comment

Looks good! Just one more thing:

Dev automation moved this from Review in progress to Reviewer approved Feb 18, 2020
@vzahradnik vzahradnik force-pushed the vzahradnik:feature/modbus-climate-register-type branch from 64611dd to 054c352 Feb 18, 2020
@springstan springstan merged commit af67bb0 into home-assistant:dev Feb 18, 2020
10 checks passed
10 checks passed
CI Build #20200218.48 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 70910ec...054c352
Details
codecov/project 94.67% (+<.01%) compared to 70910ec
Details
Dev automation moved this from Reviewer approved to Done Feb 18, 2020
@vzahradnik vzahradnik deleted the vzahradnik:feature/modbus-climate-register-type branch Feb 18, 2020
@vzahradnik vzahradnik mentioned this pull request Feb 18, 2020
6 of 20 tasks complete
@lock lock bot locked and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.