Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

deCONZ - Use proper mechanisms for options flow tests #31965



Copy link

Kane610 commented Feb 18, 2020

Generic clean up

Breaking change

Proposed change

Following @MartinHjelmare comment in #31842

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:


  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
Generic clean up
@Kane610 Kane610 requested a review from MartinHjelmare Feb 18, 2020
@Kane610 Kane610 self-assigned this Feb 18, 2020
@Kane610 Kane610 changed the title deCONZ - Use proper mechanisms for options flow deCONZ - Use proper mechanisms for options flow tests Feb 18, 2020
@project-bot project-bot bot added this to Needs review in Dev Feb 18, 2020
Dev automation moved this from Needs review to Reviewer approved Feb 18, 2020

This comment has been minimized.

Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #31965 into dev will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #31965      +/-   ##
+ Coverage   94.65%   94.69%   +0.03%     
  Files         763      766       +3     
  Lines       55164    55544     +380     
+ Hits        52218    52596     +378     
- Misses       2946     2948       +2
Impacted Files Coverage 螖
homeassistant/components/demo/ 62.85% <0%> (-37.15%) 猬囷笍
homeassistant/util/ 95.83% <0%> (-1.61%) 猬囷笍
homeassistant/helpers/ 97.27% <0%> (-0.35%) 猬囷笍
homeassistant/components/mqtt/ 97.11% <0%> (-0.02%) 猬囷笍
homeassistant/components/deconz/ 100% <0%> (酶) 猬嗭笍
homeassistant/components/deconz/ 98.03% <0%> (酶) 猬嗭笍
homeassistant/components/deconz/ 100% <0%> (酶) 猬嗭笍
...omeassistant/components/soundtouch/ 100% <0%> (酶) 猬嗭笍
...ssistant/components/google_assistant/ 91.2% <0%> (酶) 猬嗭笍
homeassistant/helpers/ 99.53% <0%> (酶) 猬嗭笍
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 614be5c...bc73ce2. Read the comment docs.

@Kane610 Kane610 merged commit a745134 into home-assistant:dev Feb 18, 2020
11 checks passed
11 checks passed
CI Build #20200218.78 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 614be5c...bc73ce2
codecov/project 94.69% (+0.03%) compared to 614be5c
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Feb 18, 2020
@Kane610 Kane610 deleted the Kane610:deconz-improve_config_flow_tests branch Feb 18, 2020
@lock lock bot locked and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.