Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modbus remove unnecessary get calls #31966

merged 1 commit into from Feb 19, 2020


Copy link

vzahradnik commented Feb 18, 2020

Proposed change

This change cleans up Modbus component:

  • All occurrences of REGISTER_TYPE and INPUT_TYPE are prefixed with DEFAULT
  • All values (except optional parameters without default value) are accessed directly without dict.get() calls

This approach was suggested in PR #31944 for Modbus Climate. Now I did the same for remaining entities.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:


  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

This comment has been minimized.

Copy link

probot-home-assistant bot commented Feb 18, 2020

Hey there @adamchengtkc, mind taking a look at this pull request as its been labeled with a integration (modbus) you are listed as a codeowner for? Thanks!


This comment has been minimized.

Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #31966 into dev will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #31966      +/-   ##
+ Coverage   94.68%   94.69%   +0.01%     
  Files         764      766       +2     
  Lines       55384    55548     +164     
+ Hits        52439    52601     +162     
- Misses       2945     2947       +2
Impacted Files Coverage 螖
homeassistant/components/mqtt/ 97.11% <0%> (-0.02%) 猬囷笍
homeassistant/components/automation/ 100% <0%> (酶) 猬嗭笍
homeassistant/components/mqtt/ 100% <0%> (酶) 猬嗭笍
homeassistant/components/mqtt/ 98.47% <0%> (酶)
homeassistant/components/mqtt/ 100% <0%> (酶)
homeassistant/components/mqtt/ 98.05% <0%> (+0.05%) 猬嗭笍
homeassistant/components/unifi/ 95.78% <0%> (+0.18%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 4ed7a7f...5525d14. Read the comment docs.

Dev automation moved this from Needs review to Reviewer approved Feb 19, 2020
@balloob balloob merged commit 32cd58e into home-assistant:dev Feb 19, 2020
11 checks passed
11 checks passed
CI Build #20200218.79 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing b5df2ba...5525d14
codecov/project 94.69% (+0.01%) compared to b5df2ba
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Feb 19, 2020
@vzahradnik vzahradnik deleted the vzahradnik:modbus-cleanup branch Feb 19, 2020
@lock lock bot locked and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.