Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test for HMIPC #31981

Merged
merged 1 commit into from Feb 19, 2020
Merged

Fix test for HMIPC #31981

merged 1 commit into from Feb 19, 2020

Conversation

@SukramJ
Copy link
Contributor

SukramJ commented Feb 19, 2020

Proposed change

This fixes a test failure caused by two parallel HMIPC PRs (#31914, #31916).
My fault.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@project-bot project-bot bot added this to Needs review in Dev Feb 19, 2020
@SukramJ SukramJ requested a review from springstan Feb 19, 2020
@SukramJ

This comment has been minimized.

Copy link
Contributor Author

SukramJ commented Feb 19, 2020

Please have a look at this PR. This fixes a failing test in dev branch, that was caused by my parallel PR before.

Copy link
Member

springstan left a comment

Can be merged when the CI tests pass 鉁

Dev automation moved this from Needs review to Reviewer approved Feb 19, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #31981 into dev will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #31981   +/-   ##
=======================================
  Coverage   94.69%   94.69%           
=======================================
  Files         766      766           
  Lines       55569    55578    +9     
=======================================
+ Hits        52619    52628    +9     
  Misses       2950     2950           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 0d87490...7436f6c. Read the comment docs.

@springstan springstan merged commit da4c08d into home-assistant:dev Feb 19, 2020
11 checks passed
11 checks passed
CI Build #20200219.36 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100.00% of diff hit (target 94.69%)
Details
codecov/project 94.69% (target 90.00%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Feb 19, 2020
@SukramJ SukramJ deleted the SukramJ:patch-1 branch Feb 19, 2020
@SukramJ

This comment has been minimized.

Copy link
Contributor Author

SukramJ commented Feb 19, 2020

Thanks a lot @springstan

@springstan

This comment has been minimized.

Copy link
Member

springstan commented Feb 19, 2020

Of course @SukramJ

@frenck

This comment has been minimized.

Copy link
Member

frenck commented Feb 19, 2020

This PR just unblocked the beta release! Thanks @SukramJ for fixing that so quickly 馃憤

@lock lock bot locked and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can鈥檛 perform that action at this time.