Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ZHA quirks and add skip configuration support #31982

merged 3 commits into from Feb 19, 2020


Copy link

dmulcahey commented Feb 19, 2020

Proposed change

This PR bumps the version of the ZHA quirks module and it adds support for skipping configuration for devices that violate the Zigbee spec. This corrects joins for new Xioami devices that do honor the specification such as the new Xiaomi illumination sensors and the Opple remotes.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests


  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
dmulcahey added 2 commits Feb 17, 2020

This comment has been minimized.

Copy link

probot-home-assistant bot commented Feb 19, 2020

Hey there @Adminiuga, mind taking a look at this pull request as its been labeled with a integration (zha) you are listed as a codeowner for? Thanks!

@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Feb 19, 2020

This comment has been minimized.

Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #31982 into dev will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #31982      +/-   ##
+ Coverage   94.69%   94.69%   +<.01%     
  Files         766      766              
  Lines       55578    55578              
+ Hits        52627    52629       +2     
+ Misses       2951     2949       -2
Impacted Files Coverage 螖
homeassistant/helpers/ 97.61% <0%> (+0.34%) 猬嗭笍
homeassistant/components/androidtv/ 90.32% <0%> (+0.35%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update e90d29e...c80fa15. Read the comment docs.

Copy link

Adminiuga left a comment


Dev automation moved this from By Code Owner to Reviewer approved Feb 19, 2020
@Adminiuga Adminiuga merged commit 8255bdf into home-assistant:dev Feb 19, 2020
10 checks passed
10 checks passed
CI Build #20200219.49 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing e90d29e...c80fa15
codecov/project 94.69% (+<.01%) compared to e90d29e
Dev automation moved this from Reviewer approved to Done Feb 19, 2020
@dmulcahey dmulcahey added this to the 0.106.0 milestone Feb 19, 2020
balloob added a commit that referenced this pull request Feb 20, 2020
* add skip configuration
* Bump quirks
* add skip configuration to FakeDevice
@lock lock bot locked and limited conversation to collaborators Feb 21, 2020
@dmulcahey dmulcahey deleted the dmulcahey:dm/zha-skip-configuration branch Mar 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can鈥檛 perform that action at this time.