Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recursion bug #32009

Merged
merged 2 commits into from Feb 20, 2020
Merged

Fix recursion bug #32009

merged 2 commits into from Feb 20, 2020

Conversation

@balloob
Copy link
Member

balloob commented Feb 20, 2020

Breaking change

Proposed change

Fixes #28929

Thanks to @gjbadros for the great analysis.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@balloob balloob added this to the 0.106.0 milestone Feb 20, 2020
@balloob balloob requested a review from home-assistant/core as a code owner Feb 20, 2020
@project-bot project-bot bot added this to Needs review in Dev Feb 20, 2020
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Feb 20, 2020

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (homeassistant) you are listed as a codeowner for? Thanks!

@gjbadros

This comment has been minimized.

Copy link
Contributor

gjbadros commented Feb 20, 2020

Yay, thank you @balloob ... great to see this issue get fixed!

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 20, 2020

Codecov Report

Merging #32009 into dev will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #32009      +/-   ##
==========================================
+ Coverage   94.69%   94.69%   +<.01%     
==========================================
  Files         766      766              
  Lines       55578    55582       +4     
==========================================
+ Hits        52629    52634       +5     
+ Misses       2949     2948       -1
Impacted Files Coverage 螖
homeassistant/helpers/entity.py 97.61% <0%> (+0.34%) 猬嗭笍
homeassistant/__init__.py 89.02% <0%> (+0.56%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 5839df3...7219699. Read the comment docs.

@frenck
frenck approved these changes Feb 20, 2020
Copy link
Member

frenck left a comment

Nice one!

Dev automation moved this from Needs review to Reviewer approved Feb 20, 2020
@@ -70,10 +79,13 @@
data[ATTR_ENTITY_ID] = list(ent_ids)

tasks.append(
hass.services.async_call(domain, service.service, data, blocking)
asyncio.shield(

This comment has been minimized.

Copy link
@pvizeli

pvizeli Feb 20, 2020

Member

I think there is no reason to shield it because gather did not forward cancel events like wait.

@balloob balloob merged commit 1c2bce9 into dev Feb 20, 2020
6 of 8 checks passed
6 of 8 checks passed
CI Build #20200220.44 had test failures
Details
CI (Tests PyTest Python37) Tests PyTest Python37 failed
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
cla-bot Everyone involved has signed the CLA
Dev automation moved this from Reviewer approved to Done Feb 20, 2020
@balloob balloob deleted the fix-homeassistant-service-recursion branch Feb 20, 2020
balloob added a commit that referenced this pull request Feb 20, 2020
* Fix recursion bug

* Remove shield
@lock lock bot locked and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can鈥檛 perform that action at this time.