Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyatmo to 3.2.4 #32018

Merged
merged 3 commits into from Feb 20, 2020
Merged

Bump pyatmo to 3.2.4 #32018

merged 3 commits into from Feb 20, 2020

Conversation

@cgtobi
Copy link
Collaborator

cgtobi commented Feb 20, 2020

Breaking change

Proposed change

This bumps pyatmo to 3.2.4 to fix the netatmo integration not finding all connected modules.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #31822
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@project-bot project-bot bot added this to Needs review in Dev Feb 20, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Feb 20, 2020
Copy link
Member

springstan left a comment

Looks good 馃憤 Just one comment

requirements_test_all.txt Outdated Show resolved Hide resolved
Dev automation moved this from By Code Owner to Reviewer approved Feb 20, 2020
cgtobi added 2 commits Feb 15, 2020
@cgtobi cgtobi force-pushed the cgtobi:netatmo_fix_weather_31822 branch from ae7e8a2 to 9eee5d3 Feb 20, 2020
@balloob balloob merged commit 7e3841e into home-assistant:dev Feb 20, 2020
6 of 8 checks passed
6 of 8 checks passed
CI Build #20200220.33 had test failures
Details
CI (Tests PyTest Python37) Tests PyTest Python37 failed
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
cla-bot Everyone involved has signed the CLA
Dev automation moved this from Reviewer approved to Done Feb 20, 2020
@balloob

This comment has been minimized.

Copy link
Member

balloob commented Feb 20, 2020

Should this be in the beta?

@cgtobi

This comment has been minimized.

Copy link
Collaborator Author

cgtobi commented Feb 20, 2020

Would be good, but I鈥檓 aware that I鈥檓 late to the party. It鈥檚 just a fix anyway.

@balloob balloob added this to the 0.106.0 milestone Feb 20, 2020
balloob added a commit that referenced this pull request Feb 20, 2020
* Bump pyatmo to 3.2.3

* Bump pyatmo version to 3.2.4

* Update requirements_test_all.txt
@cgtobi cgtobi deleted the cgtobi:netatmo_fix_weather_31822 branch Feb 20, 2020
@lock lock bot locked and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can鈥檛 perform that action at this time.