Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry Plex setup if server is unavailable on startup #32071

Merged
merged 1 commit into from Feb 21, 2020

Conversation

@jjlawren
Copy link
Contributor

jjlawren commented Feb 21, 2020

Proposed change

If the Plex server is down when HA starts up, it will fail permanently. This PR retries setup using the built-in ConfigEntryNotReady exception.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #32025
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@project-bot project-bot bot added this to Needs review in Dev Feb 21, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Feb 21, 2020
Copy link
Member

Kane610 left a comment

Yes 馃憤馃徎

Dev automation moved this from By Code Owner to Reviewer approved Feb 21, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 21, 2020

Codecov Report

Merging #32071 into dev will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #32071      +/-   ##
==========================================
+ Coverage   94.72%   94.72%   +<.01%     
==========================================
  Files         767      767              
  Lines       55594    55596       +2     
==========================================
+ Hits        52662    52664       +2     
  Misses       2932     2932
Impacted Files Coverage 螖
homeassistant/components/rest/sensor.py 99.29% <0%> (+0.01%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update f32411e...1056f01. Read the comment docs.

@jjlawren jjlawren added this to the 0.106.0 milestone Feb 21, 2020
Copy link
Member

springstan left a comment

LGTM 馃帀

@springstan springstan merged commit 9cc47ca into home-assistant:dev Feb 21, 2020
11 checks passed
11 checks passed
CI Build #20200221.52 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing f32411e...1056f01
Details
codecov/project 94.72% (+<.01%) compared to f32411e
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Feb 21, 2020
@jjlawren jjlawren deleted the jjlawren:plex_retry_on_startup branch Feb 21, 2020
balloob added a commit that referenced this pull request Feb 22, 2020
@lock lock bot locked and limited conversation to collaborators Feb 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can鈥檛 perform that action at this time.